Android: Guard against switching camera on stopped camera

Android: Guard against switching camera on stopped camera

It is possible that cameraThreadHandler is null upon calling
switchCamera(). This CL adds a guard against that.

Committed: https://crrev.com/92068ee6838b20cc204c5604f5f61c0253f1ff52
Cr-Commit-Position: refs/heads/master@{#9925}

[braveyao1, 2015-09-11 08:06:33]

braveyao@webrtc.org changed reviewers:
+ braveyao@webrtc.org, magjed@webrtc.org

[braveyao1, 2015-09-11 08:06:34]

Please help to have a look.

[magjed_webrtc, 2015-09-11 11:55:02]

lgtm

https://codereview.webrtc.org/1325333003/diff/1/talk/app/webrtc/java/android/...
File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/1325333003/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:171: if
(cameraThread == null) {
Remove this check, it's unnecessary.

https://codereview.webrtc.org/1325333003/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:181: if
(cameraThreadHandler == null) {
Can you move this to the top of the function instead?

[Colin Dodd, 2015-09-11 12:23:49]

The CQ bit was checked by colin@comoyo.com

[Colin Dodd, 2015-09-11 12:23:49]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1325333003/#ps20001 (title:
"Android: Guard against switching camera on stopped camera")

[Colin Dodd, 2015-09-11 12:23:50]

The CQ bit was unchecked by colin@comoyo.com

[Colin Dodd, 2015-09-11 12:32:37]

The CQ bit was checked by colin@comoyo.com

[commit-bot: I haz the power, 2015-09-11 12:32:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325333003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325333003/20001

[commit-bot: I haz the power, 2015-09-11 13:30:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-11 13:30:52]

Patchset 2 (id:??) landed as
https://crrev.com/92068ee6838b20cc204c5604f5f61c0253f1ff52
Cr-Commit-Position: refs/heads/master@{#9925}