Make LoadObserver settable per video send stream. Gives client flexibility and makes the implementa…

Make LoadObserver settable per video send stream. Gives client flexibility and makes the implementation slightly simpler. See discussion in: https://codereview.webrtc.org/1269863005/

BUG=webrtc:4690
Committed: https://crrev.com/e5269747595864eedd604f153df5d7bcbe1b475a
Cr-Commit-Position: refs/heads/master@{#9891}

[the sun, 2015-09-03 20:32:32]

solenberg@webrtc.org changed reviewers:
+ mflodman@webrtc.org, pbos@webrtc.org

[pbos-webrtc, 2015-09-03 20:36:40]

https://codereview.webrtc.org/1325263002/diff/1/talk/media/webrtc/webrtcvideo...
File talk/media/webrtc/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1325263002/diff/1/talk/media/webrtc/webrtcvideo...
talk/media/webrtc/webrtcvideoengine2.cc:1120: config.overuse_callback = this;
Can you set WebRtcVideoSendStream::this inside the constructor instead? Or do
you want me to do that one (one adaptation per stream) in a follow-up?

[pbos-webrtc, 2015-09-03 20:44:55]

lgtm

https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:393: if (config_.overuse_callback) {
Remove {}s for consistency outside of talk/.

https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:399: if (config_.overuse_callback) {
Remove {}s for consistency outside of talk/.

[the sun, 2015-09-03 20:54:56]

https://codereview.webrtc.org/1325263002/diff/1/talk/media/webrtc/webrtcvideo...
File talk/media/webrtc/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1325263002/diff/1/talk/media/webrtc/webrtcvideo...
talk/media/webrtc/webrtcvideoengine2.cc:1120: config.overuse_callback = this;
On 2015/09/03 20:36:39, pbos-webrtc wrote:
> Can you set WebRtcVideoSendStream::this inside the constructor instead? Or do
> you want me to do that one (one adaptation per stream) in a follow-up?

I'm just changing the API and introducing the possibility, not changing the
strategy. So if we prioritize adaptation per stream, yes, do it in a follow-up.

https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:393: if (config_.overuse_callback) {
On 2015/09/03 20:44:55, pbos-webrtc wrote:
> Remove {}s for consistency outside of talk/.

lol

https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:399: if (config_.overuse_callback) {
On 2015/09/03 20:44:55, pbos-webrtc wrote:
> Remove {}s for consistency outside of talk/.

lol

[pthatcher1, 2015-09-04 04:56:03]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2015-09-04 04:56:03]

lgtm

https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:393: if (config_.overuse_callback) {
On 2015/09/03 20:54:55, the sun wrote:
> On 2015/09/03 20:44:55, pbos-webrtc wrote:
> > Remove {}s for consistency outside of talk/.
> 
> lol

Please keep {}s to be consistent with code inside of webrtc/p2p, webrtc/base,
MediaController, and WebRtcVidoeEngine2

https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:399: if (config_.overuse_callback) {
On 2015/09/03 20:54:55, the sun wrote:
> On 2015/09/03 20:44:55, pbos-webrtc wrote:
> > Remove {}s for consistency outside of talk/.
> 
> lol


Please keep {}s to be consistent with code inside of webrtc/p2p, webrtc/base,
MediaController, and WebRtcVidoeEngine2

[the sun, 2015-09-04 09:17:52]

On 2015/09/04 04:56:03, pthatcher1 wrote:
> lgtm
> 
>
https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
> File webrtc/video/video_send_stream.cc (right):
> 
>
https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
> webrtc/video/video_send_stream.cc:393: if (config_.overuse_callback) {
> On 2015/09/03 20:54:55, the sun wrote:
> > On 2015/09/03 20:44:55, pbos-webrtc wrote:
> > > Remove {}s for consistency outside of talk/.
> > 
> > lol
> 
> Please keep {}s to be consistent with code inside of webrtc/p2p, webrtc/base,
> MediaController, and WebRtcVidoeEngine2
> 
>
https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
> webrtc/video/video_send_stream.cc:399: if (config_.overuse_callback) {
> On 2015/09/03 20:54:55, the sun wrote:
> > On 2015/09/03 20:44:55, pbos-webrtc wrote:
> > > Remove {}s for consistency outside of talk/.
> > 
> > lol
> 
> 
> Please keep {}s to be consistent with code inside of webrtc/p2p, webrtc/base,
> MediaController, and WebRtcVidoeEngine2

I'll let mflodman@ have the final say regarding the {}s... :)

[pthatcher1, 2015-09-04 09:38:13]

On 2015/09/04 09:17:52, the sun wrote:
> On 2015/09/04 04:56:03, pthatcher1 wrote:
> > lgtm
> > 
> >
>
https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
> > File webrtc/video/video_send_stream.cc (right):
> > 
> >
>
https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
> > webrtc/video/video_send_stream.cc:393: if (config_.overuse_callback) {
> > On 2015/09/03 20:54:55, the sun wrote:
> > > On 2015/09/03 20:44:55, pbos-webrtc wrote:
> > > > Remove {}s for consistency outside of talk/.
> > > 
> > > lol
> > 
> > Please keep {}s to be consistent with code inside of webrtc/p2p,
webrtc/base,
> > MediaController, and WebRtcVidoeEngine2
> > 
> >
>
https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
> > webrtc/video/video_send_stream.cc:399: if (config_.overuse_callback) {
> > On 2015/09/03 20:54:55, the sun wrote:
> > > On 2015/09/03 20:44:55, pbos-webrtc wrote:
> > > > Remove {}s for consistency outside of talk/.
> > > 
> > > lol
> > 
> > 
> > Please keep {}s to be consistent with code inside of webrtc/p2p,
webrtc/base,
> > MediaController, and WebRtcVidoeEngine2
> 
> I'll let mflodman@ have the final say regarding the {}s... :)

I was kind of joking.  I'm not an owner of the webrtc/video/ directory, so it's
not my call for that directory.  Although I do hope one day the two halves of
our code base can agree on a style (hopefully the correct one).

[the sun, 2015-09-07 09:38:59]

On 2015/09/04 09:38:13, pthatcher1 wrote:
> On 2015/09/04 09:17:52, the sun wrote:
> > On 2015/09/04 04:56:03, pthatcher1 wrote:
> > > lgtm
> > > 
> > >
> >
>
https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
> > > File webrtc/video/video_send_stream.cc (right):
> > > 
> > >
> >
>
https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
> > > webrtc/video/video_send_stream.cc:393: if (config_.overuse_callback) {
> > > On 2015/09/03 20:54:55, the sun wrote:
> > > > On 2015/09/03 20:44:55, pbos-webrtc wrote:
> > > > > Remove {}s for consistency outside of talk/.
> > > > 
> > > > lol
> > > 
> > > Please keep {}s to be consistent with code inside of webrtc/p2p,
> webrtc/base,
> > > MediaController, and WebRtcVidoeEngine2
> > > 
> > >
> >
>
https://codereview.webrtc.org/1325263002/diff/1/webrtc/video/video_send_strea...
> > > webrtc/video/video_send_stream.cc:399: if (config_.overuse_callback) {
> > > On 2015/09/03 20:54:55, the sun wrote:
> > > > On 2015/09/03 20:44:55, pbos-webrtc wrote:
> > > > > Remove {}s for consistency outside of talk/.
> > > > 
> > > > lol
> > > 
> > > 
> > > Please keep {}s to be consistent with code inside of webrtc/p2p,
> webrtc/base,
> > > MediaController, and WebRtcVidoeEngine2
> > 
> > I'll let mflodman@ have the final say regarding the {}s... :)
> 
> I was kind of joking.  I'm not an owner of the webrtc/video/ directory, so
it's
> not my call for that directory.  Although I do hope one day the two halves of
> our code base can agree on a style (hopefully the correct one).

Ping mflodman@... need owner's lgtm on this one.

[mflodman, 2015-09-08 08:53:07]

lgtm

[the sun, 2015-09-08 09:25:22]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-09-08 09:25:22]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
pthatcher@webrtc.org, mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1325263002/#ps80001 (title:
"rebase")

[commit-bot: I haz the power, 2015-09-08 09:25:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325263002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325263002/80001

[commit-bot: I haz the power, 2015-09-08 09:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 09:41:20]

Try jobs failed on following builders:
  linux_msan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/4562)

[pbos-webrtc, 2015-09-08 09:44:30]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-09-08 09:44:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325263002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325263002/80001

[commit-bot: I haz the power, 2015-09-08 11:25:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 11:25:46]

Try jobs failed on following builders:
  android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2015-09-08 11:33:46]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2015-09-08 11:33:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325263002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325263002/80001

[commit-bot: I haz the power, 2015-09-08 12:13:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-08 12:13:34]

Patchset 5 (id:??) landed as
https://crrev.com/e5269747595864eedd604f153df5d7bcbe1b475a
Cr-Commit-Position: refs/heads/master@{#9891}