Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: webrtc/video_frame.h

Issue 1325153009: Add histogram for percentage of sent frames that are limited in resolution due to quality. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: add stats for number of times a frame is down scaled Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video_frame.h
diff --git a/webrtc/video_frame.h b/webrtc/video_frame.h
index d70a746daeb49334193c99d522cefd275615981c..7e55008c6c55e4659b4fb83012993ff44a5fb6db 100644
--- a/webrtc/video_frame.h
+++ b/webrtc/video_frame.h
@@ -181,6 +181,16 @@ class EncodedImage {
EncodedImage(uint8_t* buffer, size_t length, size_t size)
: _buffer(buffer), _length(length), _size(size) {}
+ struct AdaptReason {
+ AdaptReason()
+ : quality_available(false),
+ quality_resolution_downscales(0) {}
+
+ bool quality_available; // True if |quality_resolution_downscales| is
mflodman 2015/10/02 09:21:51 I don't fully understand this comment. Is it true
åsapersson 2015/10/06 11:26:39 It is true if we might downscale (the quality scal
mflodman 2015/10/07 11:18:58 Does it make sense to skip the bool and do somethi
åsapersson 2015/10/09 12:17:07 Done. Removed bool.
+ // provided.
+ int quality_resolution_downscales; // Number of times this frame is down
+ // scaled in resolution due to quality.
+ };
uint32_t _encodedWidth = 0;
uint32_t _encodedHeight = 0;
uint32_t _timeStamp = 0;
@@ -193,6 +203,7 @@ class EncodedImage {
size_t _length;
size_t _size;
bool _completeFrame = false;
+ AdaptReason adapt_reason_;
};
} // namespace webrtc
« webrtc/video/send_statistics_proxy.cc ('K') | « webrtc/video/send_statistics_proxy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698