Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1325153009: Add histogram for percentage of sent frames that are limited in resolution due to quality. (Closed)

Created:
5 years, 3 months ago by åsapersson
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add histogram for percentage of sent frames that are limited in resolution due to quality: - "WebRTC.Video.QualityLimitedResolutionInPercent" and if a frame is downscaled, the average number of times the frame is downscaled: - "WebRTC.Video.QualityLimitedResolutionDownscales" BUG= Committed: https://crrev.com/4306fc70d778887d8a2ea71b6f4bc6a12d1d9447 Cr-Commit-Position: refs/heads/master@{#10319}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 7

Patch Set 4 : add stats for number of times a frame is down scaled #

Total comments: 15

Patch Set 5 : rebase #

Patch Set 6 : #

Patch Set 7 : rebase #

Patch Set 8 : removed bool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -9 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 2 3 4 5 6 7 4 chunks +14 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/utility/include/quality_scaler.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 2 3 4 5 6 7 2 chunks +21 lines, -0 lines 0 comments Download
M webrtc/video_frame.h View 1 2 3 4 5 6 7 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
stefan-webrtc
https://codereview.webrtc.org/1325153009/diff/40001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/1325153009/diff/40001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc#newcode1019 webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1019: quality_scaler_.downscale_shift() > 0; Would it be more useful to ...
5 years, 3 months ago (2015-09-16 07:36:58 UTC) #2
stefan-webrtc
https://codereview.webrtc.org/1325153009/diff/40001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/1325153009/diff/40001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc#newcode1019 webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1019: quality_scaler_.downscale_shift() > 0; On 2015/09/16 07:36:57, stefan-webrtc (holmer) wrote: ...
5 years, 3 months ago (2015-09-16 07:37:35 UTC) #3
åsapersson
https://codereview.webrtc.org/1325153009/diff/40001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/1325153009/diff/40001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc#newcode1019 webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1019: quality_scaler_.downscale_shift() > 0; On 2015/09/16 07:37:35, stefan-webrtc (holmer) wrote: ...
5 years, 3 months ago (2015-09-17 14:24:45 UTC) #4
stefan-webrtc
https://codereview.webrtc.org/1325153009/diff/60001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/1325153009/diff/60001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc#newcode1013 webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1013: encoded_images_[encoder_idx].adapt_reason_.quality_available = quality_scaling_available? https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video/send_statistics_proxy.cc File webrtc/video/send_statistics_proxy.cc (right): https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video/send_statistics_proxy.cc#newcode72 webrtc/video/send_statistics_proxy.cc:72: ...
5 years, 3 months ago (2015-09-23 15:08:08 UTC) #6
åsapersson
https://codereview.webrtc.org/1325153009/diff/60001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/1325153009/diff/60001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc#newcode1013 webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1013: encoded_images_[encoder_idx].adapt_reason_.quality_available = On 2015/09/23 15:08:07, stefan-webrtc (holmer) wrote: > ...
5 years, 3 months ago (2015-09-24 08:16:17 UTC) #7
stefan-webrtc
lgtm https://codereview.webrtc.org/1325153009/diff/60001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/1325153009/diff/60001/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc#newcode1013 webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1013: encoded_images_[encoder_idx].adapt_reason_.quality_available = On 2015/09/24 08:16:17, åsapersson wrote: > ...
5 years, 2 months ago (2015-09-28 13:44:29 UTC) #8
pbos-webrtc
lgtm https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video/send_statistics_proxy.cc File webrtc/video/send_statistics_proxy.cc (right): https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video/send_statistics_proxy.cc#newcode177 webrtc/video/send_statistics_proxy.cc:177: if (encoded_image._length > 0) { != kSkipFrame please ...
5 years, 2 months ago (2015-09-28 14:30:18 UTC) #9
mflodman
https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video/send_statistics_proxy.h File webrtc/video/send_statistics_proxy.h (right): https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video/send_statistics_proxy.h#newcode107 webrtc/video/send_statistics_proxy.h:107: void Add(bool sample); On 2015/09/28 14:30:18, pbos-webrtc wrote: > ...
5 years, 2 months ago (2015-10-02 09:21:51 UTC) #10
åsapersson
https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video/send_statistics_proxy.h File webrtc/video/send_statistics_proxy.h (right): https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video/send_statistics_proxy.h#newcode107 webrtc/video/send_statistics_proxy.h:107: void Add(bool sample); On 2015/10/02 09:21:51, mflodman wrote: > ...
5 years, 2 months ago (2015-10-06 11:26:39 UTC) #11
mflodman
https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video/send_statistics_proxy.h File webrtc/video/send_statistics_proxy.h (right): https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video/send_statistics_proxy.h#newcode107 webrtc/video/send_statistics_proxy.h:107: void Add(bool sample); On 2015/10/06 11:26:39, åsapersson wrote: > ...
5 years, 2 months ago (2015-10-07 11:18:59 UTC) #12
åsapersson
https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video_frame.h File webrtc/video_frame.h (right): https://codereview.webrtc.org/1325153009/diff/60001/webrtc/video_frame.h#newcode189 webrtc/video_frame.h:189: bool quality_available; // True if |quality_resolution_downscales| is On 2015/10/07 ...
5 years, 2 months ago (2015-10-09 12:17:07 UTC) #13
mflodman
LGTM
5 years, 2 months ago (2015-10-16 11:45:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325153009/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325153009/140001
5 years, 2 months ago (2015-10-19 06:48:01 UTC) #17
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 2 months ago (2015-10-19 07:35:25 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 07:35:40 UTC) #19
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/4306fc70d778887d8a2ea71b6f4bc6a12d1d9447
Cr-Commit-Position: refs/heads/master@{#10319}

Powered by Google App Engine
This is Rietveld 408576698