Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: talk/session/media/channel_unittest.cc

Issue 1325023005: Remove Channel::SetRingbackTone() and Channel::PlayRingbackTone(), and the code beneath it (within … (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/session/media/channel.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/session/media/channel_unittest.cc
diff --git a/talk/session/media/channel_unittest.cc b/talk/session/media/channel_unittest.cc
index 9020cafcec23fd46a611c07b15f1e23609ec53c0..22b1aef4074374e927b1c7ba02d431238f030e4e 100644
--- a/talk/session/media/channel_unittest.cc
+++ b/talk/session/media/channel_unittest.cc
@@ -2091,33 +2091,6 @@ TEST_F(VoiceChannelTest, TestOnReadyToSendWithRtcpMux) {
Base::TestOnReadyToSendWithRtcpMux();
}
-// Test that we can play a ringback tone properly.
-TEST_F(VoiceChannelTest, TestRingbackTone) {
- CreateChannels(RTCP, RTCP);
- EXPECT_FALSE(media_channel1_->ringback_tone_play());
- EXPECT_TRUE(channel1_->SetRingbackTone("RIFF", 4));
- EXPECT_TRUE(SendInitiate());
- EXPECT_TRUE(SendAccept());
- // Play ringback tone, no loop.
- EXPECT_TRUE(channel1_->PlayRingbackTone(0, true, false));
- EXPECT_EQ(0U, media_channel1_->ringback_tone_ssrc());
- EXPECT_TRUE(media_channel1_->ringback_tone_play());
- EXPECT_FALSE(media_channel1_->ringback_tone_loop());
- // Stop the ringback tone.
- EXPECT_TRUE(channel1_->PlayRingbackTone(0, false, false));
- EXPECT_FALSE(media_channel1_->ringback_tone_play());
- // Add a stream.
- EXPECT_TRUE(AddStream1(1));
- // Play ringback tone, looping, on the new stream.
- EXPECT_TRUE(channel1_->PlayRingbackTone(1, true, true));
- EXPECT_EQ(1U, media_channel1_->ringback_tone_ssrc());
- EXPECT_TRUE(media_channel1_->ringback_tone_play());
- EXPECT_TRUE(media_channel1_->ringback_tone_loop());
- // Stop the ringback tone.
- EXPECT_TRUE(channel1_->PlayRingbackTone(1, false, false));
- EXPECT_FALSE(media_channel1_->ringback_tone_play());
-}
-
// Test that we can scale the output volume properly for 1:1 calls.
TEST_F(VoiceChannelTest, TestScaleVolume1to1Call) {
CreateChannels(RTCP, RTCP);
« no previous file with comments | « talk/session/media/channel.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698