Remove cricket::VideoFrame::Set/GetElapsedTime()

Remove cricket::VideoFrame::Set/GetElapsedTime()

This CL is a baby step towards consolidating the timestamps in cricket::VideoFrame and webrtc::VideoFrame, so that we can unify the frame classes in the future.

The elapsed time functionality is not really used. If a video sink wants to know the elapsed time since the first frame they can store the first timestamp themselves and calculate the time delta to later frames. This is already done in all video sinks that need the elapsed time. Having redundant timestamps in the frame classes is confusing and error prone.

TBR=pthatcher@webrtc.org

Committed: https://crrev.com/b09b660c53ff2c499d149e05e5c435f5057273fc
Cr-Commit-Position: refs/heads/master@{#10131}

[magjed_webrtc, 2015-09-04 11:33:08]

Patchset #2 (id:20001) has been deleted

[magjed_webrtc, 2015-09-04 11:33:16]

Patchset #2 (id:40001) has been deleted

[magjed_webrtc, 2015-09-07 14:31:27]

Patchset #2 (id:60001) has been deleted

[magjed_webrtc, 2015-09-07 14:31:33]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2015-09-09 08:42:21]

magjed@webrtc.org changed reviewers:
+ pbos@webrtc.org, pthatcher@webrtc.org

[magjed_webrtc, 2015-09-09 08:51:59]

Please take a look. There is one remaining place in Chromium that uses
GetElapsedTime(), in MediaStreamRemoteVideoSource::RemoteVideoSourceDelegate. If
you approve of this CL, I will fix that call before landing this CL.

[pbos-webrtc, 2015-09-09 09:05:17]

love it, lgtm

[pthatcher1, 2015-09-16 04:18:02]

It looks really nice, but what are you going to do about this use here?

https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...

Do you have a CL to fix that spot?

[magjed_webrtc, 2015-09-25 14:32:45]

Patchset #2 (id:100001) has been deleted

[magjed_webrtc, 2015-09-25 14:32:52]

Patchset #2 (id:120001) has been deleted

[magjed_webrtc, 2015-09-25 15:47:35]

Patchset #2 (id:140001) has been deleted

[magjed_webrtc, 2015-09-25 16:00:25]

I have fixed that spot in Chromium now:
https://codereview.chromium.org/1360023003/

I have tried the patch locally in Chromium and it works fine, so no custom roll
should be needed. I had to re-add CapturedFrame.elapsed_time and the old version
of WebRtcVideoFrame.InitToBlack(). I will remove them once Chromium is updated.

[magjed_webrtc, 2015-09-30 16:00:22]

Ping, pthatcher - please take another look.

[pthatcher2, 2015-09-30 17:27:19]

pthatcher@chromium.org changed reviewers:
+ pthatcher@chromium.org

[pthatcher2, 2015-09-30 17:27:19]

lgtm

[magjed_webrtc, 2015-10-01 08:14:29]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2015-10-01 08:14:30]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1324263004/#ps160001 (title:
"Rebased. Re-added CapturedFrame.elapsed_time. Remove once Chromium is
updated.")

[commit-bot: I haz the power, 2015-10-01 08:14:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324263004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324263004/160001

[commit-bot: I haz the power, 2015-10-01 08:16:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 08:16:53]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1037)

[magjed_webrtc, 2015-10-01 09:16:32]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2015-10-01 09:16:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324263004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324263004/160001

[commit-bot: I haz the power, 2015-10-01 10:02:49]

Committed patchset #2 (id:160001)

[commit-bot: I haz the power, 2015-10-01 10:03:18]

Patchset 2 (id:??) landed as
https://crrev.com/b09b660c53ff2c499d149e05e5c435f5057273fc
Cr-Commit-Position: refs/heads/master@{#10131}