Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1324123002: Revert "Speculative revert of "- Move test cases for more natural ordering."" (Closed)

Created:
5 years, 3 months ago by stefan-webrtc
Modified:
5 years, 3 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Speculative revert of "- Move test cases for more natural ordering."" Did not resolve the build bot issue. This reverts commit 02d283a6ff5364d94aa88f5f5df4cfd3a5411346. BUG= TBR=solenberg@webrtc.org Committed: https://crrev.com/658910cc3cb54705672c28fffedba4e982fa3989 Cr-Commit-Position: refs/heads/master@{#9849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -359 lines) Patch
M talk/media/base/videoengine_unittest.h View 2 chunks +0 lines, -26 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2_unittest.cc View 3 chunks +145 lines, -155 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 4 chunks +142 lines, -174 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
stefan-webrtc
5 years, 3 months ago (2015-09-02 07:03:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324123002/1
5 years, 3 months ago (2015-09-02 07:03:12 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_rel on tryserver.webrtc (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/9123)
5 years, 3 months ago (2015-09-02 13:03:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324123002/1
5 years, 3 months ago (2015-09-03 08:52:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 12:48:37 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/658910cc3cb54705672c28fffedba4e982fa3989 Cr-Commit-Position: refs/heads/master@{#9849}
5 years, 3 months ago (2015-09-03 12:48:45 UTC) #9
the sun
5 years, 3 months ago (2015-09-03 20:39:35 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698