Issue 1323943012: PRESUBMIT: Exclude some files from 80-character limit check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1323943012: PRESUBMIT: Exclude some files from 80-character limit check. (Closed)

Created:
5 years, 3 months ago by kjellander_webrtc

Modified:
5 years, 3 months ago

Reviewers:
Sergiy Byelozyorov, Andrew MacDonald

CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

PRESUBMIT: Exclude some files from 80-character limit check. Exclude the following files from 80-characters line limit check: * DEPS * GN files (.gn and .gni) * GYP files (.gyp and .gypi) BUG=webrtc:4794 TESTED=Ran the presubmit check with a modified DEPS and GYP file before this change and verified it failed. Re-ran after these changes and verified it passed. I also tested editing a .cc file to be >80 chars and verified the check found it. R=andrew@webrtc.org, sergiyb@chromium.org Committed: https://chromium.googlesource.com/external/webrtc/+/632246792fb208280a048fb2497a309c5a4d3690

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	PRESUBMIT.py	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kjellander_webrtc

5 years, 3 months ago (2015-09-08 06:04:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
632246792fb208280a048fb2497a309c5a4d3690 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages