Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1323943007: VP9: Add automaticeResize to codec setting. (Closed)

Created:
5 years, 3 months ago by marpan
Modified:
5 years, 3 months ago
Reviewers:
stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VP9: Add automaticeResize to codec setting. Added unittest. This setting allows for dynamic resizing at low bitrates. Setting is off by default for now. BUG= R=mflodman@webrtc.org, stefan@webrtc.org TBR=stefan@webrtc.org Committed: https://crrev.com/f35072019be4e095b079c99be94145a237ecbe88 Cr-Commit-Position: refs/heads/master@{#9976}

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -37 lines) Patch
M webrtc/common_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 2 23 chunks +64 lines, -37 lines 1 comment Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/source/codec_database.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mflodman
On 2015/09/01 16:27:15, marpan wrote: > mailto:marpan@google.com changed reviewers: > + mailto:mflodman@webrtc.org LGTM. Is this ...
5 years, 3 months ago (2015-09-03 12:06:44 UTC) #3
stefan-webrtc
https://codereview.webrtc.org/1323943007/diff/20001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc (right): https://codereview.webrtc.org/1323943007/diff/20001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc#newcode732 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:732: // |spatial_resizei| is on, so expect one resize during ...
5 years, 3 months ago (2015-09-03 12:27:53 UTC) #4
mflodman
Hmm, my comment never made it in my previous reply. For some reason. https://codereview.webrtc.org/1323943007/diff/20001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc File ...
5 years, 3 months ago (2015-09-03 12:40:27 UTC) #5
marpan
https://codereview.webrtc.org/1323943007/diff/20001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc (right): https://codereview.webrtc.org/1323943007/diff/20001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc#newcode732 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:732: // |spatial_resizei| is on, so expect one resize during ...
5 years, 3 months ago (2015-09-04 21:45:45 UTC) #6
stefan-webrtc
Great improvement to the tests. LGTM https://codereview.webrtc.org/1323943007/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc (right): https://codereview.webrtc.org/1323943007/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc#newcode453 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:453: VideoFrameType frame_type = ...
5 years, 3 months ago (2015-09-05 10:45:49 UTC) #7
marpan
Committed patchset #3 (id:40001) manually as f35072019be4e095b079c99be94145a237ecbe88 (presubmit successful).
5 years, 3 months ago (2015-09-17 19:16:22 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 19:16:28 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f35072019be4e095b079c99be94145a237ecbe88
Cr-Commit-Position: refs/heads/master@{#9976}

Powered by Google App Engine
This is Rietveld 408576698