Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1323453003: Fixes for PNaCl build of remoting client plugin in chromium. (Closed)

Created:
5 years, 3 months ago by Sergey Ulanov
Modified:
5 years, 3 months ago
Reviewers:
jiayl, jiayl2
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixes for PNaCl build of remoting client plugin with GN. 1. Added support for PNaCl in base. 2. Separated parts of desktop_capture module that need to be compiled for PNaCl. BUG=512899 R=jiayl@chromium.org, jiayl@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/098c1de578e08a67eb1684ede6154e5d6301d624

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/base/systeminfo.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/BUILD.gn View 3 chunks +15 lines, -7 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_frame.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_region.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_region.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Sergey Ulanov
5 years, 3 months ago (2015-08-27 23:17:04 UTC) #2
jiayl
lgtm
5 years, 3 months ago (2015-08-27 23:28:34 UTC) #4
Sergey Ulanov
On 2015/08/27 23:28:34, jiayl wrote: > lgtm Thanks! Will need to land https://codereview.chromium.org/1307693003 before landing ...
5 years, 3 months ago (2015-08-27 23:29:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323453003/1
5 years, 3 months ago (2015-08-31 23:17:39 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-08-31 23:17:40 UTC) #9
jiayl2
lgtm
5 years, 3 months ago (2015-08-31 23:18:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323453003/1
5 years, 3 months ago (2015-08-31 23:21:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_rel/builds/5271)
5 years, 3 months ago (2015-08-31 23:23:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323453003/20001
5 years, 3 months ago (2015-08-31 23:32:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on ...
5 years, 3 months ago (2015-09-01 01:32:24 UTC) #19
Sergey Ulanov
5 years, 3 months ago (2015-09-01 18:36:54 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
098c1de578e08a67eb1684ede6154e5d6301d624.

Powered by Google App Engine
This is Rietveld 408576698