Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1323453002: VideoCapturerAndroid: Move to android folder and split out camera enumeration into separate file (Closed)

Created:
5 years, 3 months ago by magjed_webrtc
Modified:
5 years, 3 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid: Move to android folder and split out camera enumeration into separate file Pure code move of: talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java into: talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java talk/app/webrtc/java/android/org/webrtc/CameraEnumerationAndroid.java NOPRESUBMIT=true Committed: https://crrev.com/6813ec84fbe813e259e7b2f7d65f6d79e221e2ab Cr-Commit-Position: refs/heads/master@{#9809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -1281 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 5 chunks +9 lines, -9 lines 0 comments Download
A talk/app/webrtc/java/android/org/webrtc/CameraEnumerationAndroid.java View 1 chunk +293 lines, -0 lines 0 comments Download
A + talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 11 chunks +11 lines, -261 lines 0 comments Download
D talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java View 1 chunk +0 lines, -1006 lines 0 comments Download
M talk/libjingle.gyp View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
magjed_webrtc
Please take a look.
5 years, 3 months ago (2015-08-28 08:29:13 UTC) #2
tommi
lgtm
5 years, 3 months ago (2015-08-28 11:13:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323453002/1
5 years, 3 months ago (2015-08-28 11:22:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/540)
5 years, 3 months ago (2015-08-28 11:23:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323453002/1
5 years, 3 months ago (2015-08-28 12:22:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 12:22:23 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 12:22:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6813ec84fbe813e259e7b2f7d65f6d79e221e2ab
Cr-Commit-Position: refs/heads/master@{#9809}

Powered by Google App Engine
This is Rietveld 408576698