Avoids crashes in Java-based InitRecording()

Avoids crashes in Java-based InitRecording().

This CL ensures that we return -1 in cases where InitRecording() fails. It ensures that we don't crash applications.

BUG=b/22849644
R=magjed@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/4ed3658b7848891c014ba69c4c82693b30cb6e7f

[henrika_webrtc, 2015-09-09 15:23:53]

henrika@webrtc.org changed reviewers:
+ magjed@webrtc.org

[henrika_webrtc, 2015-09-09 15:24:29]

magjed: would a appreciate a quick check. Thanks ;-)

[magjed_webrtc, 2015-09-10 07:23:08]

https://codereview.webrtc.org/1323243012/diff/1/webrtc/modules/audio_device/a...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
(right):

https://codereview.webrtc.org/1323243012/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:152:
if (aec != null) {
When can this ever happen? Doesn't |aec| have the same lifetime as audioRecord?
|aec| is also released in StopRecording(). If you want to avoid assertTrue(),
maybe just change if-statement above to:
if (audioRecord != null || aec != null) ?

[henrika_webrtc, 2015-09-10 11:27:07]

Thanks. PTAL.

https://codereview.webrtc.org/1323243012/diff/1/webrtc/modules/audio_device/a...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
(right):

https://codereview.webrtc.org/1323243012/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:152:
if (aec != null) {
You are correct. They are correlated. Should be enough to just check
audioRecord.

[magjed_webrtc, 2015-09-10 11:30:57]

lgtm

[henrika_webrtc, 2015-09-10 11:31:39]

The CQ bit was checked by henrika@webrtc.org

[commit-bot: I haz the power, 2015-09-10 11:31:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323243012/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323243012/20001

[henrika_webrtc, 2015-09-10 13:18:39]

Committed patchset #2 (id:20001) manually as
4ed3658b7848891c014ba69c4c82693b30cb6e7f (presubmit successful).