Issue 1322703004: Do not explicitly delete OpenGL shaders in VideoRendererGui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1322703004: Do not explicitly delete OpenGL shaders in VideoRendererGui. (Closed)

Created:
5 years, 3 months ago by AlexG

Modified:
5 years, 3 months ago

Reviewers:
wzh

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald

Base URL:
https://chromium.googlesource.com/external/webrtc@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Do not explicitly delete OpenGL shaders in VideoRendererGui. This is handled by Android itself and may result in GL errors when trying to release shaders when Activity is destroyed. R=wzh@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/79de90b1100853c78594705c272528eea7b706d5

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322703004/1

5 years, 3 months ago (2015-08-28 18:37:02 UTC) #4

AlexG

5 years, 3 months ago (2015-08-28 18:47:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
79de90b1100853c78594705c272528eea7b706d5 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages