Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Issue 1321893003: CameraEnumerationAndroid: Add getSupportedFormats() implementation using android.hardware.camera2 (Closed)

Created:
5 years, 3 months ago by magjed_webrtc
Modified:
5 years, 3 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

CameraEnumerationAndroid: Add getSupportedFormats() implementation using android.hardware.camera2 Enumerating using android.hardware.camera2 is 10x faster than enumerating using android.hardware.camera, but they don't list exactly the same formats. android.hardware.camera2 support higher resolutions for some cameras, and also different framerates. R=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/e7a0de773a12a8d6efee3127582659e90feb1c4e

Patch Set 1 #

Patch Set 2 : weaker tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -0 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 2 chunks +34 lines, -0 lines 0 comments Download
A talk/app/webrtc/java/android/org/webrtc/Camera2Enumerator.java View 1 1 chunk +119 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/jni/classreferenceholder.cc View 1 chunk +1 line, -0 lines 2 comments Download
M talk/libjingle.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
magjed_webrtc
tommi - Please take a look.
5 years, 3 months ago (2015-09-01 12:38:25 UTC) #4
tommi
https://codereview.webrtc.org/1321893003/diff/40002/talk/app/webrtc/java/jni/classreferenceholder.cc File talk/app/webrtc/java/jni/classreferenceholder.cc (right): https://codereview.webrtc.org/1321893003/diff/40002/talk/app/webrtc/java/jni/classreferenceholder.cc#newcode75 talk/app/webrtc/java/jni/classreferenceholder.cc:75: LoadClass(jni, "org/webrtc/Camera2Enumerator"); Should we do this an all versions ...
5 years, 3 months ago (2015-09-01 12:48:59 UTC) #5
magjed_webrtc
https://codereview.webrtc.org/1321893003/diff/40002/talk/app/webrtc/java/jni/classreferenceholder.cc File talk/app/webrtc/java/jni/classreferenceholder.cc (right): https://codereview.webrtc.org/1321893003/diff/40002/talk/app/webrtc/java/jni/classreferenceholder.cc#newcode75 talk/app/webrtc/java/jni/classreferenceholder.cc:75: LoadClass(jni, "org/webrtc/Camera2Enumerator"); On 2015/09/01 12:48:59, tommi (webrtc) wrote: > ...
5 years, 3 months ago (2015-09-01 14:42:44 UTC) #6
tommi
lgtm
5 years, 3 months ago (2015-09-03 13:50:17 UTC) #7
magjed_webrtc
5 years, 3 months ago (2015-09-04 13:13:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40002) manually as
e7a0de773a12a8d6efee3127582659e90feb1c4e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698