Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1321023002: NetEq: Removing two asserts (Closed)

Created:
5 years, 3 months ago by hlundin-webrtc
Modified:
5 years, 3 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Removing two asserts These asserts cover error cases that are also handled by the code after the assert. Should not have both assert and error handling. BUG=webrtc:4840 Committed: https://crrev.com/98f3cc54daf0385e8b76875aa4ea0cb16987bfc5 Cr-Commit-Position: refs/heads/master@{#9804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hlundin-webrtc
Ivo, Please, take a look at this minimal CL. Thanks!
5 years, 3 months ago (2015-08-28 07:27:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321023002/1
5 years, 3 months ago (2015-08-28 07:28:19 UTC) #4
ivoc
LGTM, short but sweet.
5 years, 3 months ago (2015-08-28 07:47:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 08:11:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321023002/1
5 years, 3 months ago (2015-08-28 08:11:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 08:12:25 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 08:12:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98f3cc54daf0385e8b76875aa4ea0cb16987bfc5
Cr-Commit-Position: refs/heads/master@{#9804}

Powered by Google App Engine
This is Rietveld 408576698