Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

Issue 1320763003: Rate limit the low bandwidth / min bitrate warning to once every 10 seconds. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h
diff --git a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h
index fb8962ad5052adb080372b058ad7d0ce5a3b5f41..f50ad5184a83f99bc83d7837550fdb37948a716d 100644
--- a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h
+++ b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h
@@ -30,7 +30,7 @@ class SendSideBandwidthEstimation {
void UpdateEstimate(int64_t now_ms);
// Call when we receive a RTCP message with TMMBR or REMB.
- void UpdateReceiverEstimate(uint32_t bandwidth);
+ void UpdateReceiverEstimate(int64_t now_ms, uint32_t bandwidth);
// Call when we receive a RTCP message with a ReceiveBlock.
void UpdateReceiverBlock(uint8_t fraction_loss,
@@ -51,7 +51,7 @@ class SendSideBandwidthEstimation {
// Returns the input bitrate capped to the thresholds defined by the max,
// min and incoming bandwidth.
- uint32_t CapBitrateToThresholds(uint32_t bitrate);
+ uint32_t CapBitrateToThresholds(int64_t now_ms, uint32_t bitrate);
// Updates history of min bitrates.
// After this method returns min_bitrate_history_.front().second contains the
@@ -67,6 +67,7 @@ class SendSideBandwidthEstimation {
uint32_t bitrate_;
uint32_t min_bitrate_configured_;
uint32_t max_bitrate_configured_;
+ int64_t last_low_bitrate_log_ms_;
int64_t time_last_receiver_block_ms_;
uint8_t last_fraction_loss_;

Powered by Google App Engine
This is Rietveld 408576698