Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1319713004: Merge two files with AudioEncoderOpus tests (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Merge two files with AudioEncoderOpus tests Merge the contents of audio_encoder_mutable_opus_test.cc into audio_encoder_opus_unittest.cc, since they're now both testing AudioEncoderOpus. (While preparing this CL, I noted a bug in the PacketLossRateOptimized test. This CL leaves that test essentially unchanged; I've posted bug 4981 about the problem.) Committed: https://crrev.com/77d22fa014e6ce8e315c9703b113f0422ab07de1 Cr-Commit-Position: refs/heads/master@{#9906}

Patch Set 1 #

Patch Set 2 : windows compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -143 lines) Patch
D webrtc/modules/audio_coding/codecs/opus/audio_encoder_mutable_opus_test.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 1 2 chunks +114 lines, -33 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
hlundin-webrtc
lgtm
5 years, 3 months ago (2015-09-09 11:07:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319713004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319713004/20001
5 years, 3 months ago (2015-09-09 11:08:37 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 11:38:38 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 11:38:49 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77d22fa014e6ce8e315c9703b113f0422ab07de1
Cr-Commit-Position: refs/heads/master@{#9906}

Powered by Google App Engine
This is Rietveld 408576698