Clean up tests

- Move test cases for more natural ordering.
- Get rid of the CoInitialize tests for WVoE/WViE.

BUG=webrtc:4690
R=pbos@webrtc.org, tommi@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/c20a5dc9305b988ca173cd63e606124b02e6d54c

[the sun, 2015-08-28 12:13:45]

solenberg@webrtc.org changed reviewers:
+ tommi@webrtc.org

[the sun, 2015-08-28 12:13:46]

- Move test cases for more natural ordering.
- Get rid of the CoInitialize tests for WVoE/WViE.

[tommi, 2015-08-28 13:29:18]

tommi@webrtc.org changed reviewers:
+ pbos@webrtc.org

[tommi, 2015-08-28 13:29:18]

lgtm. peter - do you mind taking a look at the COM issue?

https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvideoengine2_unittest.cc (left):

https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvideoengine2_unittest.cc:758: // TODO(juberti): Figure
out why ViE is munging the COM refcount.
is there actually a bug in ViE in relation to this?

https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine_unittest.cc:3493: // Tests for the actual
WebRtc VoE library.
nit: Does 'actual' add anything?

[pbos-webrtc, 2015-08-28 13:31:26]

On 2015/08/28 13:29:18, tommi (webrtc) wrote:
> lgtm. peter - do you mind taking a look at the COM issue?
> 
>
https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
> File talk/media/webrtc/webrtcvideoengine2_unittest.cc (left):
> 
>
https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
> talk/media/webrtc/webrtcvideoengine2_unittest.cc:758: // TODO(juberti): Figure
> out why ViE is munging the COM refcount.
> is there actually a bug in ViE in relation to this?
> 
>
https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
> File talk/media/webrtc/webrtcvoiceengine_unittest.cc (right):
> 
>
https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
> talk/media/webrtc/webrtcvoiceengine_unittest.cc:3493: // Tests for the actual
> WebRtc VoE library.
> nit: Does 'actual' add anything?

lgtm for the COM-test removal..

This is ancient and was disabled in webrtcvideoengine.cc which I just copied
over. I don't think COM count is even remotely relevant anymore here.

[the sun, 2015-08-28 14:42:38]

https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvideoengine2_unittest.cc (left):

https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvideoengine2_unittest.cc:758: // TODO(juberti): Figure
out why ViE is munging the COM refcount.
On 2015/08/28 13:29:18, tommi (webrtc) wrote:
> is there actually a bug in ViE in relation to this?

I couldn't find a webrtc bug mentioning either "COM" or "CoInit".

https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine_unittest.cc:3493: // Tests for the actual
WebRtc VoE library.
On 2015/08/28 13:29:18, tommi (webrtc) wrote:
> nit: Does 'actual' add anything?

Well, these tests do use the *actual* VoE, rather than the
FakeWebRtcVoiceEngine...

[the sun, 2015-08-28 14:42:47]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-08-28 14:42:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1319163002/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2015-08-28 14:42:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319163002/40001

[tommi, 2015-08-28 14:46:16]

https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/1319163002/diff/20001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine_unittest.cc:3493: // Tests for the actual
WebRtc VoE library.
On 2015/08/28 14:42:37, the sun wrote:
> On 2015/08/28 13:29:18, tommi (webrtc) wrote:
> > nit: Does 'actual' add anything?
> 
> Well, these tests do use the *actual* VoE, rather than the
> FakeWebRtcVoiceEngine...

Ah I see. That wasn't clear to me :)

[commit-bot: I haz the power, 2015-08-28 16:43:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 16:43:15]

Try jobs failed on following builders:
  android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2015-08-31 08:06:43]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-08-31 08:06:43]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1319163002/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2015-08-31 08:06:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319163002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319163002/60001

[the sun, 2015-08-31 09:14:12]

Committed patchset #4 (id:60001) manually as
c20a5dc9305b988ca173cd63e606124b02e6d54c (presubmit successful).