Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318983002: Using 'override' keyword in dtlstransport.h (Closed)

Created:
5 years, 3 months ago by hbos
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Using 'override' keyword in dtlstransport.h. Chromium FYI trybots were complaining about virtual methods not being marked override. R=henrikg@webrtc.org TBR=henrikg@webrtc.org, tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/31545685c7ecd8e4cb5f6762904f1f09ff231468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M webrtc/p2p/base/dtlstransport.h View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318983002/1
5 years, 3 months ago (2015-08-27 11:04:22 UTC) #3
Henrik Grunell WebRTC
lgtm
5 years, 3 months ago (2015-08-27 11:11:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
5 years, 3 months ago (2015-08-27 13:04:34 UTC) #6
hbos
5 years, 3 months ago (2015-08-27 13:44:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
31545685c7ecd8e4cb5f6762904f1f09ff231468 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698