Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1318193003: Enable automatic resizing for RTX-enabled senders. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable automatic resizing for RTX-enabled senders. These were accidentally disabled due to checking ssrcs_.size() (which includes RTX SSRCs) instead of rtp.ssrcs.size() to determine whether a stream is simulcast or not. BUG=webrtc:4965 R=asapersson@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/2feafdb742226f57588d9c95bc25b2202166688f

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M talk/media/webrtc/webrtcvideoengine2.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2_unittest.cc View 1 4 chunks +22 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pbos-webrtc
Oops, PTAL. :|
5 years, 3 months ago (2015-09-09 11:59:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318193003/1
5 years, 3 months ago (2015-09-09 11:59:09 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-09 11:59:15 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318193003/1
5 years, 3 months ago (2015-09-09 12:00:20 UTC) #7
pbos-webrtc
fix typo
5 years, 3 months ago (2015-09-09 12:01:17 UTC) #8
åsapersson
lgtm
5 years, 3 months ago (2015-09-09 12:13:21 UTC) #9
pbos-webrtc
5 years, 3 months ago (2015-09-09 12:32:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2feafdb742226f57588d9c95bc25b2202166688f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698