Adding PeerConnectionInterface::SetConfiguration method.

Adding PeerConnectionInterface::SetConfiguration method.

Also updated the JNI and Objective-C bindings. Later, will have a CL to
remove UpdateIce, which this method effectively replaces.

BUG=webrtc:4945
Committed: https://crrev.com/70702afbcb8418fe93747e7ed63bcbf5e56b90e9
Cr-Commit-Position: refs/heads/master@{#10040}

[Taylor Brandstetter, 2015-09-03 01:11:43]

deadbeef@webrtc.org changed reviewers:
+ guoweis@webrtc.org, pthatcher@webrtc.org

[Taylor Brandstetter, 2015-09-03 01:11:43]

Note that this method already existed in PeerConnection (as an overload of
"UpdateIce"), but it wasn't referenced by anything. So I just renamed it there,
and added the new method everywhere else.

[pthatcher1, 2015-09-03 01:54:18]

lgtm

Just delete however much you can in this CL.  If not in this CL, then in later
ones.

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/PeerConnection.java (right):

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/PeerConnection.java:194: List<IceServer>
iceServers, MediaConstraints constraints);
Is this even used right now?  Can we just remove it?

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/objc/RTCP...
File talk/app/webrtc/objc/RTCPeerConnection.mm (right):

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/objc/RTCP...
talk/app/webrtc/objc/RTCPeerConnection.mm:218: }
Same here.  Is it even used?

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/peerconne...
File talk/app/webrtc/peerconnectioninterface.h (right):

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/peerconne...
talk/app/webrtc/peerconnectioninterface.h:369: const MediaConstraintsInterface*
constraints) = 0;
Can you mark this with a "TODO: Remove once Chrome as moved over to calling
SetConfiguration"?

[Taylor Brandstetter, 2015-09-03 17:42:04]

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/PeerConnection.java (right):

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/PeerConnection.java:194: List<IceServer>
iceServers, MediaConstraints constraints);
On 2015/09/03 01:54:18, pthatcher1 wrote:
> Is this even used right now?  Can we just remove it?

I guess we can, cool.

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/objc/RTCP...
File talk/app/webrtc/objc/RTCPeerConnection.mm (right):

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/objc/RTCP...
talk/app/webrtc/objc/RTCPeerConnection.mm:218: }
On 2015/09/03 01:54:18, pthatcher1 wrote:
> Same here.  Is it even used?

Appears not; removing.

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/peerconne...
File talk/app/webrtc/peerconnectioninterface.h (right):

https://codereview.webrtc.org/1317353005/diff/40001/talk/app/webrtc/peerconne...
talk/app/webrtc/peerconnectioninterface.h:369: const MediaConstraintsInterface*
constraints) = 0;
On 2015/09/03 01:54:18, pthatcher1 wrote:
> Can you mark this with a "TODO: Remove once Chrome as moved over to calling
> SetConfiguration"?

Done.

[Taylor Brandstetter, 2015-09-23 16:45:16]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2015-09-23 16:45:16]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1317353005/#ps60001 (title:
"Deleting some unused code, and adding TODO for pending deletion")

[commit-bot: I haz the power, 2015-09-23 16:45:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317353005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317353005/60001

[commit-bot: I haz the power, 2015-09-23 17:28:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 17:28:15]

Try jobs failed on following builders:
  linux_tsan2 on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/6911)

[Taylor Brandstetter, 2015-09-23 23:31:08]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2015-09-23 23:31:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317353005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317353005/60001

[commit-bot: I haz the power, 2015-09-23 23:32:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-23 23:32:55]

Patchset 4 (id:??) landed as
https://crrev.com/70702afbcb8418fe93747e7ed63bcbf5e56b90e9
Cr-Commit-Position: refs/heads/master@{#10040}

[Taylor Brandstetter, 2015-09-24 00:30:26]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.webrtc.org/1361263002/ by deadbeef@webrtc.org.

The reason for reverting is: Broke FYI bots because SetConfiguration is pure
virtual and MockPeerConnectionImpl doesn't implement it. Need to reland with
SetConfiguration not pure virtual..