Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1317243005: Turn webrtc::Vad into a pure virtual interface (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, aluebs-webrtc, bjornv1, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@ifc-merge-2
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Turn webrtc::Vad into a pure virtual interface Committed: https://crrev.com/e9e7896293747b2084e7f018675276f5096cdafc Cr-Commit-Position: refs/heads/master@{#9899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -40 lines) Patch
M webrtc/common_audio/vad/include/vad.h View 2 chunks +12 lines, -11 lines 0 comments Download
M webrtc/common_audio/vad/mock/mock_vad.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/vad/vad.cc View 1 chunk +40 lines, -26 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1322973004 Patch 80001

Messages

Total messages: 6 (2 generated)
hlundin-webrtc
lgtm
5 years, 3 months ago (2015-09-08 11:11:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317243005/1
5 years, 3 months ago (2015-09-09 06:03:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 06:04:55 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 06:05:04 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e9e7896293747b2084e7f018675276f5096cdafc
Cr-Commit-Position: refs/heads/master@{#9899}

Powered by Google App Engine
This is Rietveld 408576698