Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1316903003: fix mipsel-o32-generic compile error (Closed)

Created:
5 years, 3 months ago by bshe
Modified:
5 years, 3 months ago
Reviewers:
Peter Kasting
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

fix mipsel-o32-generic compile error TBR=turaj@webrtc.org BUG=524885

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Patch Set 3 : rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M modules/audio_coding/codecs/isac/fix/source/lattice_mips.c View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Peter Kasting
LGTM; I'm not an OWNER so you'll need to TBR one before landing. https://codereview.webrtc.org/1316903003/diff/1/modules/audio_coding/codecs/isac/fix/source/lattice_mips.c File ...
5 years, 3 months ago (2015-08-26 20:13:35 UTC) #2
bshe
https://codereview.webrtc.org/1316903003/diff/1/modules/audio_coding/codecs/isac/fix/source/lattice_mips.c File modules/audio_coding/codecs/isac/fix/source/lattice_mips.c (right): https://codereview.webrtc.org/1316903003/diff/1/modules/audio_coding/codecs/isac/fix/source/lattice_mips.c#newcode11 modules/audio_coding/codecs/isac/fix/source/lattice_mips.c:11: #include <stddef.h> On 2015/08/26 20:13:34, Peter Kasting wrote: > ...
5 years, 3 months ago (2015-08-26 20:59:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316903003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316903003/20001
5 years, 3 months ago (2015-08-26 20:59:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang/builds/7230) ios_arm64 on tryserver.webrtc (JOB_FAILED, ...
5 years, 3 months ago (2015-08-26 21:00:47 UTC) #8
Peter Kasting
5 years, 3 months ago (2015-08-26 21:38:40 UTC) #9
Peter Kasting
Landed this in https://codereview.webrtc.org/1316843003/ .
5 years, 3 months ago (2015-08-26 21:39:04 UTC) #10
bshe
5 years, 3 months ago (2015-08-26 22:04:47 UTC) #11
Message was sent while issue was closed.
On 2015/08/26 21:39:04, Peter Kasting wrote:
> Landed this in https://codereview.webrtc.org/1316843003/ .

great! looks like I was changing the code in the managed version of webrtc. So
the patch failed on trybots.
anyway, thanks.

Powered by Google App Engine
This is Rietveld 408576698