webrtc/tools/agc/activity_metric.cc - Issue 1316523002: Convert channel counts to size_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/tools/agc/activity_metric.cc

Issue 1316523002: Convert channel counts to size_t. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Rebase onto cleanup change Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/tools/agc/activity_metric.cc

diff --git a/webrtc/tools/agc/activity_metric.cc b/webrtc/tools/agc/activity_metric.cc

index 55280fb0d5c7976d53b7b46001ea07ed3d21b966..2cb0a1b2df8baf03eb52da8d1e85719abd7a476c 100644

--- a/webrtc/tools/agc/activity_metric.cc

+++ b/webrtc/tools/agc/activity_metric.cc

@@ -56,7 +56,7 @@ namespace webrtc {

// silence frame. Otherwise true VAD would drift with respect to the audio.

// We only consider mono inputs.

static void DitherSilence(AudioFrame* frame) {

- ASSERT_EQ(1, frame->num_channels_);

+ ASSERT_EQ(1u, frame->num_channels_);

const double kRmsSilence = 5;

const double sum_squared_silence = kRmsSilence * kRmsSilence *

frame->samples_per_channel_;