Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1315923003: Revert of Added send-thresholding and fixed text packet dumping. (Closed)

Created:
5 years, 3 months ago by tommi
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added send-thresholding and fixed text packet dumping. (patchset #4 id:160001 of https://codereview.webrtc.org/1266033005/ ) Reason for revert: The CL adds a global variable. Original issue's description: > Added send-thresholding and fixed text packet dumping. Also a little squelch for the over-max-MTU log spam we see in there. > > BUG=https://code.google.com/p/webrtc/issues/detail?id=4468 > R=pthatcher@chromium.org, pthatcher@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/d838d2791979bb50f464a61c557d55c6a324621e TBR=pthatcher@webrtc.org,bemasc@webrtc.org,pthatcher@chromium.org,thakis@chromium.org,lally@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=https://code.google.com/p/webrtc/issues/detail?id=4468 Committed: https://crrev.com/7391881f9762ccadeeb0249560b33cf2bcfaf7f9 Cr-Commit-Position: refs/heads/master@{#9796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -110 lines) Patch
M talk/media/sctp/sctpdataengine.h View 4 chunks +1 line, -12 lines 0 comments Download
M talk/media/sctp/sctpdataengine.cc View 9 chunks +8 lines, -75 lines 0 comments Download
M talk/media/sctp/sctpdataengine_unittest.cc View 4 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommi
Created Revert of Added send-thresholding and fixed text packet dumping.
5 years, 3 months ago (2015-08-27 11:29:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315923003/1
5 years, 3 months ago (2015-08-27 11:29:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 11:30:02 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 11:30:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7391881f9762ccadeeb0249560b33cf2bcfaf7f9
Cr-Commit-Position: refs/heads/master@{#9796}

Powered by Google App Engine
This is Rietveld 408576698