Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: talk/media/webrtc/webrtcvoiceengine.h

Issue 1315903004: ABANDONED: Remove the default receive channel in WVoE. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@mediacontroller
Patch Set: test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | talk/media/webrtc/webrtcvoiceengine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/webrtc/webrtcvoiceengine.h
diff --git a/talk/media/webrtc/webrtcvoiceengine.h b/talk/media/webrtc/webrtcvoiceengine.h
index 0ba4b37241c7da87223fcd2429b78c1cebd6bb73..1b93309bdac09a969cef32585113f31ea0dd0264 100644
--- a/talk/media/webrtc/webrtcvoiceengine.h
+++ b/talk/media/webrtc/webrtcvoiceengine.h
@@ -259,9 +259,7 @@ class WebRtcVoiceMediaChannel : public VoiceMediaChannel,
const std::vector<AudioCodec>& all_codecs,
webrtc::CodecInst* send_codec);
bool EnableRtcp(int channel);
- bool ResetRecvCodecs(int channel);
bool SetPlayout(int channel, bool playout);
- static uint32 ParseSsrc(const void* data, size_t len, bool rtcp);
static Error WebRtcErrorToChannelError(int err_code);
class WebRtcVoiceChannelRenderer;
@@ -282,9 +280,6 @@ class WebRtcVoiceMediaChannel : public VoiceMediaChannel,
void ConfigureSendChannel(int channel);
bool ConfigureRecvChannel(int channel);
bool DeleteChannel(int channel);
- bool InConferenceMode() const {
- return options_.conference_mode.GetWithDefaultIfUnset(false);
- }
bool IsDefaultChannel(int channel_id) const {
return channel_id == default_send_channel_id_;
}
@@ -324,16 +319,15 @@ class WebRtcVoiceMediaChannel : public VoiceMediaChannel,
SendFlags send_;
webrtc::Call* const call_;
+ bool using_default_recv_channel_;
+ uint32_t default_recv_ssrc_;
+
// send_channels_ contains the channels which are being used for sending.
// When the default channel (default_send_channel_id) is used for sending, it
// is contained in send_channels_, otherwise not.
ChannelMap send_channels_;
std::vector<RtpHeaderExtension> send_extensions_;
- uint32 default_receive_ssrc_;
- // Note the default channel (default_send_channel_id()) can reside in both
- // receive_channels_ and send_channels_ in non-conference mode and in that
- // case it will only be there if a non-zero default_receive_ssrc_ is set.
- ChannelMap receive_channels_; // for multiple sources
+ ChannelMap receive_channels_;
std::map<uint32, webrtc::AudioReceiveStream*> receive_streams_;
std::map<uint32, StreamParams> receive_stream_params_;
// receive_channels_ can be read from WebRtc callback thread. Access from
@@ -341,10 +335,6 @@ class WebRtcVoiceMediaChannel : public VoiceMediaChannel,
// Reads on the worker thread are ok.
std::vector<RtpHeaderExtension> receive_extensions_;
std::vector<webrtc::RtpExtension> recv_rtp_extensions_;
-
- // Do not lock this on the VoE media processor thread; potential for deadlock
- // exists.
- mutable rtc::CriticalSection receive_channels_cs_;
};
} // namespace cricket
« no previous file with comments | « no previous file | talk/media/webrtc/webrtcvoiceengine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698