Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1315833003: NetEq: Allow negative shift in BackgroundNoise::SaveParameters (Closed)

Created:
5 years, 4 months ago by hlundin-webrtc
Modified:
5 years, 3 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Allow negative shift in BackgroundNoise::SaveParameters This change allows a shift factor to be negative. This is the way it was in the old (NetEq3) code; see https://chromium.googlesource.com/external/webrtc/+/4d363ae305fa975e7f3ad2a5ca5dbe5e3f101f82/webrtc/modules/audio_coding/neteq/bgn_update.c, lines 183-188. Some input signals can lead to negative shifts, and would then trigger an assert. The assert is now removed. BUG=webrtc:4840 R=minyue@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/3c4ef29140fb1a5e488899e1905a62277f0d9858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M webrtc/modules/audio_coding/neteq/background_noise.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hlundin-webrtc
Minyue, Please, take a look at this CL. This fixes a diff that crept in ...
5 years, 4 months ago (2015-08-25 13:30:23 UTC) #2
minyue-webrtc
lgtm
5 years, 3 months ago (2015-08-30 21:51:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315833003/1
5 years, 3 months ago (2015-08-31 05:41:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 3 months ago (2015-08-31 07:41:49 UTC) #7
hlundin-webrtc
5 years, 3 months ago (2015-08-31 08:18:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c4ef29140fb1a5e488899e1905a62277f0d9858 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698