Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1315803004: Disable race dependent test (Closed)

Created:
5 years, 3 months ago by philipel
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable VideoSendStreamTest.VP9FlexMode. Test is racy and fails on bots. BUG=webrtc:4969 R=pbos@webrtc.org, sprang@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/f325d2118c7d0e631121522be6ddd8eca8a215e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/video/video_send_stream_tests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
philipel
5 years, 3 months ago (2015-09-04 13:09:20 UTC) #2
sprang_webrtc
lgtm +pbos@, ptal
5 years, 3 months ago (2015-09-04 13:12:18 UTC) #4
pbos-webrtc
file a bug, assign it to you and and reference it through BUG= :)
5 years, 3 months ago (2015-09-04 13:12:49 UTC) #5
sprang_webrtc
5 years, 3 months ago (2015-09-04 13:15:45 UTC) #6
pbos-webrtc
On 2015/09/04 13:15:45, språng wrote: lgtm, but: Suggested CL description: Disable VideoSendStreamTest.VP9FlexMode. Test is racy ...
5 years, 3 months ago (2015-09-04 13:17:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315803004/1
5 years, 3 months ago (2015-09-04 13:17:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_arm64_rel on ...
5 years, 3 months ago (2015-09-04 15:18:01 UTC) #11
philipel
5 years, 3 months ago (2015-09-08 10:47:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f325d2118c7d0e631121522be6ddd8eca8a215e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698