Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1315503003: Set the IceConnectionReceivingTimeout as a RTCConfiguration parameter. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/peerconnectioninterface.h
diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h
index ee81f7c91677847c01b2c09c9e78daa5344d770f..195d04efd75fe9c175fc49cf1fb0fd860e062950 100644
--- a/talk/app/webrtc/peerconnectioninterface.h
+++ b/talk/app/webrtc/peerconnectioninterface.h
@@ -247,6 +247,8 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
TcpCandidatePolicy tcp_candidate_policy;
int audio_jitter_buffer_max_packets;
bool audio_jitter_buffer_fast_accelerate;
+ // ICE connection receiving timeout value in milliseconds.
+ int ice_connection_receiving_timeout;
std::vector<rtc::scoped_refptr<rtc::RTCCertificate>> certificates;
RTCConfiguration()
@@ -256,7 +258,8 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
rtcp_mux_policy(kRtcpMuxPolicyNegotiate),
tcp_candidate_policy(kTcpCandidatePolicyEnabled),
audio_jitter_buffer_max_packets(50),
juberti1 2015/08/26 18:25:46 let's put these as constants in the RTCConfigurati
honghaiz3 2015/08/26 19:20:26 Done (for integer parameters).
- audio_jitter_buffer_fast_accelerate(false) {}
+ audio_jitter_buffer_fast_accelerate(false),
+ ice_connection_receiving_timeout(2500) {}
};
struct RTCOfferAnswerOptions {
@@ -358,8 +361,6 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// The |observer| callback will be called when done.
virtual void SetRemoteDescription(SetSessionDescriptionObserver* observer,
SessionDescriptionInterface* desc) = 0;
- // Sets the ICE connection receiving timeout value in milliseconds.
- virtual void SetIceConnectionReceivingTimeout(int timeout_ms) {}
// Restarts or updates the ICE Agent process of gathering local candidates
// and pinging remote candidates.
virtual bool UpdateIce(const IceServers& configuration,

Powered by Google App Engine
This is Rietveld 408576698