Chromium Code Reviews| Index: talk/app/webrtc/peerconnectioninterface.h |
| diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h |
| index ee81f7c91677847c01b2c09c9e78daa5344d770f..bb7fe886308201d1dcd1eabf4ca8a4b0b1ebfa7c 100644 |
| --- a/talk/app/webrtc/peerconnectioninterface.h |
| +++ b/talk/app/webrtc/peerconnectioninterface.h |
| @@ -233,6 +233,11 @@ class PeerConnectionInterface : public rtc::RefCountInterface { |
| // TODO(hbos): Change into class with private data and public getters. |
| struct RTCConfiguration { |
| + // Default maximum number of packets in the audio jitter buffer. |
| + static const int kAudioJitterBufferMaxPackets = 50; |
| + // Default ICE connection receiving timeout value in milliseconds. |
| + // When this is negative, it has no effect on the internal timeout setting. |
| + static const int kIceConnectionReceivingTimeout = -1; |
|
juberti
2015/08/27 20:31:04
If you are using -1, I don't think we need to have
honghaiz3
2015/08/27 21:02:26
I just used the kUndefined as it was done in the n
|
| // TODO(pthatcher): Rename this ice_transport_type, but update |
| // Chromium at the same time. |
| IceTransportsType type; |
| @@ -247,6 +252,7 @@ class PeerConnectionInterface : public rtc::RefCountInterface { |
| TcpCandidatePolicy tcp_candidate_policy; |
| int audio_jitter_buffer_max_packets; |
| bool audio_jitter_buffer_fast_accelerate; |
| + int ice_connection_receiving_timeout; |
| std::vector<rtc::scoped_refptr<rtc::RTCCertificate>> certificates; |
| RTCConfiguration() |
| @@ -255,8 +261,9 @@ class PeerConnectionInterface : public rtc::RefCountInterface { |
| bundle_policy(kBundlePolicyBalanced), |
| rtcp_mux_policy(kRtcpMuxPolicyNegotiate), |
| tcp_candidate_policy(kTcpCandidatePolicyEnabled), |
| - audio_jitter_buffer_max_packets(50), |
| - audio_jitter_buffer_fast_accelerate(false) {} |
| + audio_jitter_buffer_max_packets(kAudioJitterBufferMaxPackets), |
| + audio_jitter_buffer_fast_accelerate(false), |
| + ice_connection_receiving_timeout(kIceConnectionReceivingTimeout) {} |
| }; |
| struct RTCOfferAnswerOptions { |
| @@ -358,8 +365,6 @@ class PeerConnectionInterface : public rtc::RefCountInterface { |
| // The |observer| callback will be called when done. |
| virtual void SetRemoteDescription(SetSessionDescriptionObserver* observer, |
| SessionDescriptionInterface* desc) = 0; |
| - // Sets the ICE connection receiving timeout value in milliseconds. |
| - virtual void SetIceConnectionReceivingTimeout(int timeout_ms) {} |
| // Restarts or updates the ICE Agent process of gathering local candidates |
| // and pinging remote candidates. |
| virtual bool UpdateIce(const IceServers& configuration, |