Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315413002: Wire up currently-received video codec to stats. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
mflodman, pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, perkj_webrtc, andresp, jiayl2
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Wire up currently-received video codec to stats. BUG=webrtc:1844, webrtc:4808 R=mflodman@webrtc.org, pthatcher@webrtc.org Committed: https://crrev.com/f42376c60111edba6f29060bf3dd79e75d8dbb97 Cr-Commit-Position: refs/heads/master@{#9810}

Patch Set 1 #

Total comments: 6

Patch Set 2 : feedback #

Patch Set 3 : remove != NULL #

Patch Set 4 : nuke ViEDecoderObserver #

Patch Set 5 : remove some callback registration #

Patch Set 6 : only report payload type in VCMReceiveCallback #

Total comments: 4

Patch Set 7 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -124 lines) Patch
M talk/app/webrtc/statscollector.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/interface/video_coding_defines.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/codec_database.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 2 3 4 5 2 chunks +10 lines, -16 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 2 3 4 5 1 chunk +14 lines, -10 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 2 3 4 2 chunks +1 line, -7 lines 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 2 3 4 5 6 chunks +2 lines, -39 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 2 3 4 5 6 8 chunks +17 lines, -48 lines 0 comments Download
M webrtc/video_receive_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (4 generated)
pbos-webrtc
PTAL, if this can jump you guys' review queues I think jiayl@ will be happy. ...
5 years, 3 months ago (2015-08-27 16:45:51 UTC) #1
pbos-webrtc
On 2015/08/27 16:45:51, pbos-webrtc wrote: > PTAL, if this can jump you guys' review queues ...
5 years, 3 months ago (2015-08-27 16:46:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315413002/1
5 years, 3 months ago (2015-08-27 16:46:18 UTC) #4
pthatcher1
lgtm For talk/webrtc parts. https://codereview.webrtc.org/1315413002/diff/1/talk/media/webrtc/webrtcvideoengine2.cc File talk/media/webrtc/webrtcvideoengine2.cc (right): https://codereview.webrtc.org/1315413002/diff/1/talk/media/webrtc/webrtcvideoengine2.cc#newcode2626 talk/media/webrtc/webrtcvideoengine2.cc:2626: } Would be easier to ...
5 years, 3 months ago (2015-08-27 16:50:50 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 3 months ago (2015-08-27 18:46:26 UTC) #7
mflodman
https://codereview.webrtc.org/1315413002/diff/1/webrtc/video_engine/vie_channel.cc File webrtc/video_engine/vie_channel.cc (right): https://codereview.webrtc.org/1315413002/diff/1/webrtc/video_engine/vie_channel.cc#newcode1073 webrtc/video_engine/vie_channel.cc:1073: receive_stats_callback_->OnIncomingPayloadType(codec.plType); We should either reuse 'ViEDecoderObserver::IncomingCodecChanged' or remove 'ViEDecoderObserver::IncomingCodecChanged', ...
5 years, 3 months ago (2015-08-28 09:46:06 UTC) #8
pbos-webrtc
feedback
5 years, 3 months ago (2015-08-28 10:40:03 UTC) #9
pbos-webrtc
remove != NULL
5 years, 3 months ago (2015-08-28 10:41:15 UTC) #10
pbos-webrtc
https://codereview.webrtc.org/1315413002/diff/1/talk/media/webrtc/webrtcvideoengine2.cc File talk/media/webrtc/webrtcvideoengine2.cc (right): https://codereview.webrtc.org/1315413002/diff/1/talk/media/webrtc/webrtcvideoengine2.cc#newcode2626 talk/media/webrtc/webrtcvideoengine2.cc:2626: } On 2015/08/27 16:50:50, pthatcher1 wrote: > Would be ...
5 years, 3 months ago (2015-08-28 10:41:20 UTC) #11
mflodman
LGTM, but it would be great to remove the channel argument to ViEDecoderObserver::IncomingCodecChanged at the ...
5 years, 3 months ago (2015-08-28 10:48:07 UTC) #12
pbos-webrtc
nuke ViEDecoderObserver
5 years, 3 months ago (2015-08-28 11:43:42 UTC) #13
pbos-webrtc
remove some callback registration
5 years, 3 months ago (2015-08-28 12:09:10 UTC) #14
pbos-webrtc
On 2015/08/28 10:48:07, mflodman wrote: > LGTM, but it would be great to remove the ...
5 years, 3 months ago (2015-08-28 12:11:06 UTC) #15
pbos-webrtc
only report payload type in VCMReceiveCallback
5 years, 3 months ago (2015-08-28 12:19:49 UTC) #16
mflodman
LGTM, two comments. https://codereview.webrtc.org/1315413002/diff/100001/webrtc/video_engine/vie_channel.cc File webrtc/video_engine/vie_channel.cc (right): https://codereview.webrtc.org/1315413002/diff/100001/webrtc/video_engine/vie_channel.cc#newcode1233 webrtc/video_engine/vie_channel.cc:1233: int32_t ViEChannel::OnInitializeDecoder( TODO to remove this ...
5 years, 3 months ago (2015-08-28 12:30:11 UTC) #17
pbos-webrtc
feedback
5 years, 3 months ago (2015-08-28 12:35:08 UTC) #18
pbos-webrtc
https://codereview.webrtc.org/1315413002/diff/100001/webrtc/video_engine/vie_channel.cc File webrtc/video_engine/vie_channel.cc (right): https://codereview.webrtc.org/1315413002/diff/100001/webrtc/video_engine/vie_channel.cc#newcode1233 webrtc/video_engine/vie_channel.cc:1233: int32_t ViEChannel::OnInitializeDecoder( On 2015/08/28 12:30:11, mflodman wrote: > TODO ...
5 years, 3 months ago (2015-08-28 12:36:07 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315413002/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315413002/110001
5 years, 3 months ago (2015-08-28 12:36:15 UTC) #22
commit-bot: I haz the power
Committed patchset #7 (id:110001)
5 years, 3 months ago (2015-08-28 14:35:37 UTC) #23
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 14:35:52 UTC) #24
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/f42376c60111edba6f29060bf3dd79e75d8dbb97
Cr-Commit-Position: refs/heads/master@{#9810}

Powered by Google App Engine
This is Rietveld 408576698