Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1315323008: Disable flaky tests on Dr. Memory. (Closed)

Created:
5 years, 3 months ago by åsapersson
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : added one more test #

Patch Set 3 : added test #

Patch Set 4 : added test #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M tools/valgrind-webrtc/gtest_exclude/libjingle_media_unittest.gtest-drmemory_win32.txt View 1 3 1 chunk +15 lines, -0 lines 0 comments Download
M tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
åsapersson
5 years, 3 months ago (2015-09-08 12:40:54 UTC) #4
pbos-webrtc
lgtm
5 years, 3 months ago (2015-09-08 12:41:20 UTC) #5
kjellander_webrtc
The last three builds shows also a failure in video_engine_tests test EndToEndTest.AssignsTransportSequenceNumbers add to this ...
5 years, 3 months ago (2015-09-08 13:39:59 UTC) #6
åsapersson
On 2015/09/08 13:39:59, kjellander (webrtc) wrote: > The last three builds shows also a failure ...
5 years, 3 months ago (2015-09-08 14:10:58 UTC) #7
kjellander_webrtc
thanks! lgtm
5 years, 3 months ago (2015-09-08 14:12:32 UTC) #8
åsapersson
Committed patchset #7 (id:120001) manually as 76b3147bd81af4d5a6ea13baefe5be2f0f7570f0 (presubmit successful).
5 years, 3 months ago (2015-09-08 14:21:50 UTC) #9
kjellander_webrtc
5 years, 3 months ago (2015-09-09 07:30:28 UTC) #10
Message was sent while issue was closed.
On 2015/09/08 14:21:50, åsapersson wrote:
> Committed patchset #7 (id:120001) manually as
> 76b3147bd81af4d5a6ea13baefe5be2f0f7570f0 (presubmit successful).

Turns out WebRtcVideoChannel2BaseTest.GetStatsMultipleSendStreams also fails
Maybe the suppression should be WebRtcVideoChannel2BaseTest.* ?

Powered by Google App Engine
This is Rietveld 408576698