Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314593002: Fix Chromium GN build problem introduced in 608c3cfe (Closed)

Created:
5 years, 4 months ago by kwiberg-webrtc
Modified:
5 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kwiberg-webrtc
This fixes the Chromium GN build problem for me locally. Currently running try jobs to ...
5 years, 4 months ago (2015-08-24 11:44:23 UTC) #2
Henrik Grunell WebRTC
lgtm
5 years, 4 months ago (2015-08-24 11:59:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314593002/1
5 years, 4 months ago (2015-08-24 12:00:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-24 14:00:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314593002/1
5 years, 4 months ago (2015-08-24 17:39:38 UTC) #9
kwiberg-webrtc
5 years, 4 months ago (2015-08-24 17:50:55 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
39b8eb3ab0a105166f3fd4c0fd7e0637712864b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698