Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1313873003: Reland: Implement NetEq's CurrentDelay function (Closed)

Created:
5 years, 4 months ago by hlundin-webrtc
Modified:
5 years, 3 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland: Implement NetEq's CurrentDelay function This was not implemented before. It returns the current total delay (packet buffer and sync buffer) of NetEq. This is the same information that was already available in NetEqNetworkStatistics::current_buffer_size_ms, that can be obtained through NetEq::NetworkStatistics(). But, since the current delay is a key metric of NetEq, it is convenient to have it available in a simpler way. This is a re-landing of r9359, https://webrtc-codereview.appspot.com/51149004, which was reverted in r9360. The refactoring made in r9669 facilitated the relanding. TBR=minyue@webrtc.org Committed: https://crrev.com/9c3efd00523a81d0f2b582799fbe67afe44139b2 Cr-Commit-Position: refs/heads/master@{#9801}

Patch Set 1 #

Patch Set 2 : Fixing win64 build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M webrtc/modules/audio_coding/neteq/interface/neteq.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 2 chunks +15 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
minyue-webrtc
may better rename to "Reland ..."
5 years, 4 months ago (2015-08-25 11:45:04 UTC) #1
hlundin-webrtc
On 2015/08/25 11:45:04, minyue-webrtc wrote: > may better rename to "Reland ..." Of course. Thanks!
5 years, 4 months ago (2015-08-25 12:09:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313873003/1
5 years, 3 months ago (2015-08-26 19:19:08 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_gn on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn/builds/3643)
5 years, 3 months ago (2015-08-26 19:25:03 UTC) #6
hlundin-webrtc
Fixing win64 build
5 years, 3 months ago (2015-08-27 11:36:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313873003/20001
5 years, 3 months ago (2015-08-27 11:40:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
5 years, 3 months ago (2015-08-27 13:40:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313873003/20001
5 years, 3 months ago (2015-08-27 20:11:35 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-27 20:12:27 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 20:12:37 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c3efd00523a81d0f2b582799fbe67afe44139b2
Cr-Commit-Position: refs/heads/master@{#9801}

Powered by Google App Engine
This is Rietveld 408576698