Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1313563002: Java VideoRenderer.Callbacks: Make renderFrame() interface asynchronous (Closed)

Created:
5 years, 4 months ago by magjed_webrtc
Modified:
5 years, 3 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Java VideoRenderer.Callbacks: Make renderFrame() interface asynchronous This CL makes the Java render interface asynchronous by requiring every call to renderFrame() to be followed by an explicit renderFrameDone() call. In JNI, this is implemented with cricket::VideoFrame::Copy() before calling renderFrame(), and a corresponding call to delete in renderFrameDone(). This CL is primarily done to prepare for a new renderer implementation. BUG=webrtc:4742, webrtc:4909 R=glaznev@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/a6cba3ab5c899339d577adf1824e0e007c12863e

Patch Set 1 : Reland from https://codereview.webrtc.org/1257043004/ #

Patch Set 2 : Add test that reproduces issue webrtc:4909 #

Patch Set 3 : Rebase and rerun tests #

Total comments: 6

Patch Set 4 : Addressing Alex's comments #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -10 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 2 3 4 3 chunks +79 lines, -0 lines 0 comments Download
M talk/app/webrtc/androidvideocapturer.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 1 2 3 4 6 chunks +7 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 2 3 4 5 chunks +12 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/VideoRenderer.java View 1 2 3 8 chunks +32 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
magjed_webrtc
Please take a look. This is a partial reland of the SurfaceViewRenderer CL: https://codereview.webrtc.org/1257043004 I ...
5 years, 4 months ago (2015-08-25 16:32:49 UTC) #2
AlexG
I think with this change it's worth to move to async rendering in VideoRendererGui as ...
5 years, 3 months ago (2015-08-26 23:27:25 UTC) #4
magjed_webrtc
After this CL lands, I can remove I420Frame.copyFrom() in a follow-up CL. It does not ...
5 years, 3 months ago (2015-08-27 15:52:20 UTC) #5
AlexG
lgtm
5 years, 3 months ago (2015-08-28 18:08:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313563002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313563002/80001
5 years, 3 months ago (2015-08-29 13:06:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang/builds/7285) android_gn_rel on tryserver.webrtc (JOB_FAILED, ...
5 years, 3 months ago (2015-08-29 13:06:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313563002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313563002/100001
5 years, 3 months ago (2015-08-29 13:12:29 UTC) #13
magjed_webrtc
5 years, 3 months ago (2015-08-29 13:58:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:100001) manually as
a6cba3ab5c899339d577adf1824e0e007c12863e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698