Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313513002: Android RendererCommon: Add unittests for getDisplaySize() (Closed)

Created:
5 years, 4 months ago by magjed_webrtc
Modified:
5 years, 4 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -1 line) Patch
A talk/app/webrtc/androidtests/src/org/webrtc/RendererCommonTest.java View 1 chunk +90 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/RendererCommon.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313513002/1
5 years, 4 months ago (2015-08-23 10:53:36 UTC) #2
magjed_webrtc
Please take a look.
5 years, 4 months ago (2015-08-24 10:23:56 UTC) #5
AlexG
lgtm
5 years, 4 months ago (2015-08-24 18:26:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313513002/20001
5 years, 4 months ago (2015-08-25 07:32:46 UTC) #8
magjed_webrtc
5 years, 4 months ago (2015-08-25 10:31:35 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) manually as
7230a21d66eb7d71f35b7362d23dcd5199635e56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698