Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1312763013: Cleanup: Remove duplicated functions (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/peerconnection.cc ('k') | talk/app/webrtc/webrtcsession.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 class StatsObserver : public rtc::RefCountInterface { 120 class StatsObserver : public rtc::RefCountInterface {
121 public: 121 public:
122 virtual void OnComplete(const StatsReports& reports) = 0; 122 virtual void OnComplete(const StatsReports& reports) = 0;
123 123
124 protected: 124 protected:
125 virtual ~StatsObserver() {} 125 virtual ~StatsObserver() {}
126 }; 126 };
127 127
128 class MetricsObserverInterface : public rtc::RefCountInterface { 128 class MetricsObserverInterface : public rtc::RefCountInterface {
129 public: 129 public:
130 // TODO(guoweis): Remove this function once IncrementEnumCounter gets into
131 // chromium. IncrementCounter only deals with one type of enumeration counter,
132 // i.e. PeerConnectionAddressFamilyCounter. Instead of creating a function for
133 // each enum type, IncrementEnumCounter is generalized with the enum type
134 // parameter.
135 virtual void IncrementCounter(PeerConnectionAddressFamilyCounter type) {}
136 130
137 // |type| is the type of the enum counter to be incremented. |counter| 131 // |type| is the type of the enum counter to be incremented. |counter|
138 // is the particular counter in that type. |counter_max| is the next sequence 132 // is the particular counter in that type. |counter_max| is the next sequence
139 // number after the highest counter. 133 // number after the highest counter.
140 virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type, 134 virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type,
141 int counter, 135 int counter,
142 int counter_max) {} 136 int counter_max) {}
143 137
144 virtual void AddHistogramSample(PeerConnectionMetricsName type, 138 virtual void AddHistogramSample(PeerConnectionMetricsName type,
145 int value) = 0; 139 int value) = 0;
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 CreatePeerConnectionFactory( 598 CreatePeerConnectionFactory(
605 rtc::Thread* worker_thread, 599 rtc::Thread* worker_thread,
606 rtc::Thread* signaling_thread, 600 rtc::Thread* signaling_thread,
607 AudioDeviceModule* default_adm, 601 AudioDeviceModule* default_adm,
608 cricket::WebRtcVideoEncoderFactory* encoder_factory, 602 cricket::WebRtcVideoEncoderFactory* encoder_factory,
609 cricket::WebRtcVideoDecoderFactory* decoder_factory); 603 cricket::WebRtcVideoDecoderFactory* decoder_factory);
610 604
611 } // namespace webrtc 605 } // namespace webrtc
612 606
613 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_ 607 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/peerconnection.cc ('k') | talk/app/webrtc/webrtcsession.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698