Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1312763013: Cleanup: Remove duplicated functions (Closed)

Created:
5 years, 3 months ago by guoweis_webrtc
Modified:
5 years, 3 months ago
Reviewers:
pthatcher2, pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleanup: Remove duplicated functions IncrementCounter has been replaced by IncrementEnumCounter. Since the code has been rolled into Chromium, time to clean this up. R=pthatcher@chromium.org TBR=pthatcher@webrtc.org BUG= Committed: https://chromium.googlesource.com/external/webrtc/+/dfbe679dedfa7048c4951138d192c07d65e268cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M talk/app/webrtc/peerconnection.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 chunk +0 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
guoweis_webrtc
PTAL
5 years, 3 months ago (2015-09-03 23:04:03 UTC) #2
pthatcher2
lgtm
5 years, 3 months ago (2015-09-03 23:57:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312763013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312763013/1
5 years, 3 months ago (2015-09-04 00:09:24 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-04 00:09:26 UTC) #8
guoweis_webrtc
5 years, 3 months ago (2015-09-04 00:12:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dfbe679dedfa7048c4951138d192c07d65e268cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698