Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1312643004: Replaces SSLIdentity* with scoped_refptr<RTCCertificate> in cricket::Transport layer. (Closed)

Created:
5 years, 4 months ago by hbos
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replaces SSLIdentity* with scoped_refptr<RTCCertificate> in the cricket::Transport layer. Why the replacements? Mainly two reasons: 1) RTCCertificate owns the identity and as long as things are referencing the identity there should be a scoped_refptr reference to the RTCCertificate. Handing out raw pointers is less memory safe. 2) With the latest RFC, an RTCCertificate should be sufficient for specifying a crypto cert and the code should be updated to use RTCCertificate instead of SSLIdentity directly. This replace work is split up into multiple CLs. In this CL... - WebRtcSessionDescriptionFactory is updated to use RTCCertificate over SSLIdentity. - WebRtcSessionDescriptionFactory::SignalCertificateReady is connected to WebRtcSession::OnCertificateReady and WebRtcSession is updated to use RTCCertificate. - The cricket::Transport and related classes are updated to use RTCCertificate. These are called from WebRtcSession::OnCertificateReady. BUG=webrtc:4927 R=tommi@webrtc.org, torbjorng@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/d82819892a382899a82ced756a9922a84ca9ca98

Patch Set 1 #

Total comments: 21

Patch Set 2 : Addressed comments #

Patch Set 3 : certificate_for_testing() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -147 lines) Patch
M talk/app/webrtc/statscollector.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M talk/app/webrtc/webrtcsession.h View 1 chunk +4 lines, -3 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 2 4 chunks +14 lines, -17 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.h View 3 chunks +6 lines, -3 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M talk/session/media/channel_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/p2p/base/dtlstransport.h View 1 9 chunks +25 lines, -12 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 1 11 chunks +40 lines, -36 lines 0 comments Download
M webrtc/p2p/base/fakesession.h View 1 8 chunks +26 lines, -18 lines 0 comments Download
M webrtc/p2p/base/session.h View 1 2 4 chunks +12 lines, -5 lines 0 comments Download
M webrtc/p2p/base/session.cc View 1 5 chunks +13 lines, -11 lines 0 comments Download
M webrtc/p2p/base/transport.h View 1 4 chunks +10 lines, -6 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
hbos
PTAL tommi & torbjorng. This is 1 of 3 "repl SSLIdentity* w scoped_refptr<RTCCertificate>" CLs.
5 years, 4 months ago (2015-08-25 09:07:21 UTC) #2
tommi
https://codereview.webrtc.org/1312643004/diff/1/webrtc/p2p/base/dtlstransport.h File webrtc/p2p/base/dtlstransport.h (right): https://codereview.webrtc.org/1312643004/diff/1/webrtc/p2p/base/dtlstransport.h#newcode44 webrtc/p2p/base/dtlstransport.h:44: const rtc::scoped_refptr<rtc::RTCCertificate>& certificate) override { since this is a ...
5 years, 4 months ago (2015-08-25 10:28:08 UTC) #3
hbos
Addressed comments https://codereview.webrtc.org/1312643004/diff/1/webrtc/p2p/base/dtlstransport.h File webrtc/p2p/base/dtlstransport.h (right): https://codereview.webrtc.org/1312643004/diff/1/webrtc/p2p/base/dtlstransport.h#newcode44 webrtc/p2p/base/dtlstransport.h:44: const rtc::scoped_refptr<rtc::RTCCertificate>& certificate) override { On 2015/08/25 ...
5 years, 4 months ago (2015-08-25 15:45:44 UTC) #6
tommi
lgtm https://codereview.webrtc.org/1312643004/diff/1/webrtc/p2p/base/session.cc File webrtc/p2p/base/session.cc (right): https://codereview.webrtc.org/1312643004/diff/1/webrtc/p2p/base/session.cc#newcode394 webrtc/p2p/base/session.cc:394: if (certificate_ || !certificate) On 2015/08/25 15:45:44, hbos ...
5 years, 4 months ago (2015-08-25 16:34:53 UTC) #7
hbos
https://codereview.webrtc.org/1312643004/diff/1/webrtc/p2p/base/session.h File webrtc/p2p/base/session.h (right): https://codereview.webrtc.org/1312643004/diff/1/webrtc/p2p/base/session.h#newcode321 webrtc/p2p/base/session.h:321: return certificate_; On 2015/08/25 16:34:53, tommi (webrtc) wrote: > ...
5 years, 3 months ago (2015-08-26 10:10:29 UTC) #8
torbjorng (webrtc)
lgtm
5 years, 3 months ago (2015-08-26 15:05:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312643004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312643004/80001
5 years, 3 months ago (2015-08-26 15:09:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on ...
5 years, 3 months ago (2015-08-26 17:09:44 UTC) #14
hbos
5 years, 3 months ago (2015-08-27 08:12:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:80001) manually as
d82819892a382899a82ced756a9922a84ca9ca98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698