Issue 1312523004: Fix AppRTCDemo crash when room is connected after PC is destroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1312523004: Fix AppRTCDemo crash when room is connected after PC is destroyed. (Closed)

Created:
5 years, 3 months ago by AlexG

Modified:
5 years, 3 months ago

Reviewers:
wzh

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald

Base URL:
https://chromium.googlesource.com/external/webrtc@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Fix AppRTCDemo crash when room is connected after PC is destroyed. Also move VideoRendererGui.dispose() to the section with public API. BUG=4909 R=wzh@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c47a01d6477da02fddeca23a4efb32f5764af128

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -20 lines)			Patch
	M	talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java	View		2 chunks	+21 lines, -19 lines	0 comments	Download
	M	webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

AlexG

5 years, 3 months ago (2015-08-26 23:02:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c47a01d6477da02fddeca23a4efb32f5764af128 (presubmit successful).