Add option to enable ECDSA key for Java API.

talk/app/webrtc/java/jni/peerconnection_jni.cc

 /*
  * libjingle
  * Copyright 2013 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 107 matching lines @@
 using webrtc::VideoSourceInterface;
 using webrtc::VideoTrackInterface;
 using webrtc::VideoTrackVector;
 using webrtc::kVideoCodecVP8;
 
 namespace webrtc_jni {
 
 // Field trials initialization string
 static char *field_trials_init_string = NULL;
 
+// Passed to SSLIdentity::Generate, "WebRTC". Used for the certificates'
+// subject and issuer name.
+static const char kIdentityName[] = "WebRTC";
+
 #if defined(ANDROID) && !defined(WEBRTC_CHROMIUM_BUILD)
 // Set in PeerConnectionFactory_initializeAndroidGlobals().
 static bool factory_static_initialized = false;
 static bool vp8_hw_acceleration_enabled = true;
 #endif
 
 extern "C" jint JNIEXPORT JNICALL JNI_OnLoad(JavaVM *jvm, void *reserved) {
   jint ret = InitGlobalJniVariables(jvm);
   if (ret < 0)
     return -1;
@@ skipping 1196 matching lines @@
   rtc_config.rtcp_mux_policy =
       JavaRtcpMuxPolicyToNativeType(jni, j_rtcp_mux_policy);
   rtc_config.tcp_candidate_policy =
       JavaTcpCandidatePolicyToNativeType(jni, j_tcp_candidate_policy);
   JavaIceServersToJsepIceServers(jni, j_ice_servers, &rtc_config.servers);
   rtc_config.audio_jitter_buffer_max_packets =
       GetIntField(jni, j_rtc_config, j_audio_jitter_buffer_max_packets_id);
   rtc_config.audio_jitter_buffer_fast_accelerate = GetBooleanField(
       jni, j_rtc_config, j_audio_jitter_buffer_fast_accelerate_id);
 
+  // Create ECDSA certificate.

[hbos, 2015/08/26 09:50:04]

This should probably not be placed here without having to explicitly enable it.
This would otherwise enable it for everything using this Java API which we do
not want to do.

I suggest adding a #ifdef JNI_CREATEPEERCONNECTION_USE_ECDSA (or if you can
think of a better name) around this code until we have added proper support to
control the certificates from the Java layers. You can build with this flag if
you want to do testing in the mean time.

Alternatively you could have a boolean flag or key type enum on the
RTCConfiguration that you would set from the application layer, but that could
only be temporary since the Java layer need to resemble the WebRTC RFC.

[AlexG, 2015/08/31 19:07:23]

Done. Added Java enum to configure certificate type

+  scoped_ptr<rtc::SSLIdentity> ssl_identity(
+      rtc::SSLIdentity::Generate(kIdentityName, rtc::KT_ECDSA));
+  if (ssl_identity.get()) {
+    rtc_config.certificates.push_back(
+        rtc::RTCCertificate::Create(ssl_identity.Pass()));
+    LOG(LS_INFO) << "ECDSA certificate created.";
+  } else {
+    LOG(LS_WARNING) << "Failed to generate SSLIdentity.";

[hbos, 2015/08/26 09:50:04]

While failing to generate is (exceptionally?) rare, it can happen. When this
happens this will not abort. Is that on purpose?

The peer connection subsequently created will use the default key type
(currently RSA, EC some time in the future, but you should not expect it to use
a specific type if you do not tell it to do so).

If it is on purpose, please add a comment clarifying that the peer connection
will created with default key type (and perhaps update the log message as well).
Otherwise, crash or find a way to abort safely.

[AlexG, 2015/08/31 19:07:23]

Done. Yes, this is on purpose. I added comment and updated log message.

+  }
+
   PCOJava* observer = reinterpret_cast<PCOJava*>(observer_p);
   observer->SetConstraints(new ConstraintsWrapper(jni, j_constraints));
   rtc::scoped_refptr<PeerConnectionInterface> pc(f->CreatePeerConnection(
       rtc_config, observer->constraints(), NULL, NULL, observer));
   return (jlong)pc.release();
 }
 
 static rtc::scoped_refptr<PeerConnectionInterface> ExtractNativePC(
     JNIEnv* jni, jobject j_pc) {
   jfieldID native_pc_id = GetFieldID(jni,
@@ skipping 323 matching lines @@
 }
 
 JOW(void, VideoTrack_nativeRemoveRenderer)(
     JNIEnv* jni, jclass,
     jlong j_video_track_pointer, jlong j_renderer_pointer) {
   reinterpret_cast<VideoTrackInterface*>(j_video_track_pointer)->RemoveRenderer(
       reinterpret_cast<VideoRendererInterface*>(j_renderer_pointer));
 }
 
 }  // namespace webrtc_jni