Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311903004: Replacing SSLIdentity* with scoped_refptr<RTCCertificate> in TransportDescriptionFactory layer (Closed)

Created:
5 years, 3 months ago by hbos
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replacing SSLIdentity* with scoped_refptr<RTCCertificate> in the cricket::TransportDescriptionFactory layers. Updates TransportDescriptionFactory, calls and unittests. BUG=webrtc:4927 R=tommi@webrtc.org, torbjorng@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/3a14bf311f366602ebc72314ca8906be61a70da4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -38 lines) Patch
M talk/app/webrtc/webrtcsession_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M talk/session/media/mediasession_unittest.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.h View 3 chunks +11 lines, -5 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory_unittest.cc View 8 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hbos
PTAL. "Replace CL" 2/3.
5 years, 3 months ago (2015-08-27 08:49:30 UTC) #2
tommi
lgtm
5 years, 3 months ago (2015-08-27 11:23:12 UTC) #3
torbjorng (webrtc)
lgtm
5 years, 3 months ago (2015-08-28 13:15:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311903004/1
5 years, 3 months ago (2015-08-28 13:17:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 3 months ago (2015-08-28 15:18:02 UTC) #8
hbos
5 years, 3 months ago (2015-08-31 07:28:20 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3a14bf311f366602ebc72314ca8906be61a70da4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698