Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1311893009: Do not use HW H.264 encoder on Nexus 7. (Closed)

Created:
5 years, 3 months ago by AlexG
Modified:
5 years, 3 months ago
Reviewers:
jiayl2
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not use HW H.264 encoder on Nexus 7. H.264 HW encoder on some Nexus 7 models have poor bitrate control. R=jiayl@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/194cceadae19a105074d4998408f06186ed43e42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
AlexG
PTAL
5 years, 3 months ago (2015-08-31 22:46:48 UTC) #2
jiayl2
lgtm There may be more devices having the problem. Can we detect this in code ...
5 years, 3 months ago (2015-09-01 16:47:56 UTC) #3
AlexG
On 2015/09/01 16:47:56, jiayl2 wrote: > lgtm > > There may be more devices having ...
5 years, 3 months ago (2015-09-01 17:36:08 UTC) #4
AlexG
5 years, 3 months ago (2015-09-01 17:36:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
194cceadae19a105074d4998408f06186ed43e42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698