Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311753002: Make jni_helpers build on arm32. (Closed)

Created:
5 years, 4 months ago by phoglund
Modified:
5 years, 3 months ago
Reviewers:
jiayl2, henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make jni_helpers build on arm32. BUG=None Committed: https://crrev.com/6480d03f176888999b56a2fa09ddf368f5ff5913 Cr-Commit-Position: refs/heads/master@{#9806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M talk/app/webrtc/java/jni/jni_helpers.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
phoglund
5 years, 4 months ago (2015-08-24 11:27:29 UTC) #2
henrika_webrtc
LGTM
5 years, 4 months ago (2015-08-24 11:47:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311753002/1
5 years, 3 months ago (2015-08-26 13:08:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/503)
5 years, 3 months ago (2015-08-26 13:10:08 UTC) #7
phoglund
Jiayang, please take a look.
5 years, 3 months ago (2015-08-26 13:19:25 UTC) #9
jiayl2
lgtm
5 years, 3 months ago (2015-08-27 16:37:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311753002/1
5 years, 3 months ago (2015-08-28 07:56:37 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 09:58:45 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 09:58:55 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6480d03f176888999b56a2fa09ddf368f5ff5913
Cr-Commit-Position: refs/heads/master@{#9806}

Powered by Google App Engine
This is Rietveld 408576698