webrtc/voice_engine/channel.h - Issue 1311733003: Stylizing AudioConferenceMixer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/channel.h

Issue 1311733003: Stylizing AudioConferenceMixer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: refine two commenting Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/voice_engine/channel.h

diff --git a/webrtc/voice_engine/channel.h b/webrtc/voice_engine/channel.h

index 43bdeb84737a64242c0993dc4b9787709e46258b..5ecd3a67c688bb09ede2af1bf9969d13f9e93f23 100644

--- a/webrtc/voice_engine/channel.h

+++ b/webrtc/voice_engine/channel.h

@@ -379,8 +379,8 @@ public:

int SendRTCPPacket(int /*channel*/, const void* data, size_t len) override;

// From MixerParticipant

- int32_t GetAudioFrame(int32_t id, AudioFrame& audioFrame) override;

- int32_t NeededFrequency(int32_t id) override;

+ int32_t GetAudioFrame(int32_t id, AudioFrame* audioFrame) override;

+ int32_t NeededFrequency(int32_t id) const override;

// From FileCallback

void PlayNotification(int32_t id, uint32_t durationMs) override;