Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: webrtc/video/send_statistics_proxy.h

Issue 1311533012: Add histogram for percentage of sent frames that are limited in resolution due to bandwidth. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc ('k') | webrtc/video/send_statistics_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/send_statistics_proxy.h
diff --git a/webrtc/video/send_statistics_proxy.h b/webrtc/video/send_statistics_proxy.h
index cd2327e2aa85213ee1d2b06f04f469938112db03..7451bb57e8126a74113f5d34a89bb413a25b5ccc 100644
--- a/webrtc/video/send_statistics_proxy.h
+++ b/webrtc/video/send_statistics_proxy.h
@@ -87,8 +87,10 @@ class SendStatisticsProxy : public CpuOveruseMetricsObserver,
uint32_t ssrc) override;
private:
- struct SampleCounter {
+ class SampleCounter {
+ public:
SampleCounter() : sum(0), num_samples(0) {}
+ ~SampleCounter() {}
void Add(int sample);
int Avg(int min_required_samples) const;
@@ -96,8 +98,10 @@ class SendStatisticsProxy : public CpuOveruseMetricsObserver,
int sum;
int num_samples;
};
- struct BoolSampleCounter {
+ class BoolSampleCounter {
+ public:
BoolSampleCounter() : sum(0), num_samples(0) {}
+ ~BoolSampleCounter() {}
void Add(bool sample);
int Percent(int min_required_samples) const;
int Permille(int min_required_samples) const;
@@ -136,6 +140,8 @@ class SendStatisticsProxy : public CpuOveruseMetricsObserver,
BoolSampleCounter key_frame_counter_ GUARDED_BY(crit_);
BoolSampleCounter quality_limited_frame_counter_ GUARDED_BY(crit_);
SampleCounter quality_downscales_counter_ GUARDED_BY(crit_);
+ BoolSampleCounter bw_limited_frame_counter_ GUARDED_BY(crit_);
+ SampleCounter bw_resolutions_disabled_counter_ GUARDED_BY(crit_);
};
} // namespace webrtc
« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc ('k') | webrtc/video/send_statistics_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698