Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311533010: Remove AudioEncoder methods SetMaxBitrate and SetMaxPayloadSize (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@ifc-merge-2
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove AudioEncoder methods SetMaxBitrate and SetMaxPayloadSize And the corresponding ACM methods SetISACMaxRate and SetISACMaxPayloadSize. They were only used in tests. Committed: https://crrev.com/c99ebc1490ec689f5932d7731a215ca02ab30af6 Cr-Commit-Position: refs/heads/master@{#9903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -158 lines) Patch
M webrtc/modules/audio_coding/codecs/audio_encoder.h View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/include/audio_encoder_cng.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 1 chunk +0 lines, -14 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M webrtc/modules/audio_coding/main/interface/audio_coding_module.h View 1 chunk +0 lines, -34 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/iSACTest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/iSACTest.cc View 3 chunks +0 lines, -44 lines 0 comments Download

Depends on Patchset:

Issue 1322973004 Patch 80001

Messages

Total messages: 7 (2 generated)
kwiberg-webrtc
😊
5 years, 3 months ago (2015-09-08 11:48:26 UTC) #2
hlundin-webrtc
Good riddance! LGTM
5 years, 3 months ago (2015-09-08 12:41:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311533010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311533010/1
5 years, 3 months ago (2015-09-09 07:36:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 07:54:12 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 07:54:19 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c99ebc1490ec689f5932d7731a215ca02ab30af6
Cr-Commit-Position: refs/heads/master@{#9903}

Powered by Google App Engine
This is Rietveld 408576698