Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

Issue 1311453002: Use RtcpPacket to send APP in RtcpSender (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
index 843ec1605d095828ae5efdd87e06d1c66ebcc933..d9b975af73162ccad133e5f3f0c29bac4f2ea4ba 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
@@ -389,6 +389,21 @@ TEST_F(RtcpSenderTest, SendApp) {
parser()->app_item()->DataLength()));
}
+TEST_F(RtcpSenderTest, SendEmptyApp) {
+ const uint8_t kSubType = 30;
+ const uint32_t kName = 0x6E616D65;
+
+ EXPECT_EQ(
+ 0, rtcp_sender_->SetApplicationSpecificData(kSubType, kName, nullptr, 0));
+
+ rtcp_sender_->SetRTCPStatus(kRtcpNonCompound);
+ EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpApp));
+ EXPECT_EQ(1, parser()->app()->num_packets());
+ EXPECT_EQ(kSubType, parser()->app()->SubType());
+ EXPECT_EQ(kName, parser()->app()->Name());
+ EXPECT_EQ(0, parser()->app_item()->num_packets());
+}
+
TEST_F(RtcpSenderTest, SetInvalidApplicationSpecificData) {
const uint8_t kData[] = {'t', 'e', 's', 't', 'd', 'a', 't'};
const uint16_t kInvalidDataLength = sizeof(kData) / sizeof(kData[0]);
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698