Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1311353011: Remove AsyncHttpRequest, AutoPortAllocator, ConnectivityChecker, and HttpPortAllocator (Closed)

Created:
5 years, 3 months ago by pthatcher1
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove AsyncHttpRequest, AutoPortAllocator, ConnectivityChecker, and HttpPortAllocator. BUG=webrtc:4149, webrtc:4456 R=deadbeef@webrtc.org, pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/d415629de78b84bf539fda7f634996e159b0dcaa

Patch Set 1 #

Patch Set 2 : Add empty files back. #

Patch Set 3 : merge #

Patch Set 4 : undo chromium change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1888 lines) Patch
M webrtc/base/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/base/asynchttprequest.h View 1 1 chunk +2 lines, -104 lines 0 comments Download
D webrtc/base/asynchttprequest.cc View 1 1 chunk +2 lines, -116 lines 0 comments Download
D webrtc/base/asynchttprequest_unittest.cc View 1 chunk +0 lines, -234 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/base_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/p2p/client/connectivitychecker.h View 1 chunk +0 lines, -281 lines 0 comments Download
D webrtc/p2p/client/connectivitychecker.cc View 1 2 1 chunk +0 lines, -529 lines 0 comments Download
D webrtc/p2p/client/connectivitychecker_unittest.cc View 1 chunk +0 lines, -367 lines 0 comments Download
M webrtc/p2p/client/httpportallocator.h View 2 chunks +6 lines, -38 lines 0 comments Download
M webrtc/p2p/client/httpportallocator.cc View 1 2 4 chunks +3 lines, -104 lines 0 comments Download
M webrtc/p2p/client/portallocator_unittest.cc View 1 2 1 chunk +0 lines, -106 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/p2p/p2p_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
pthatcher1
5 years, 3 months ago (2015-09-02 22:09:46 UTC) #2
Taylor Brandstetter
lgtm Cheers for removing more dead code!
5 years, 3 months ago (2015-09-03 01:01:50 UTC) #3
pbos-webrtc
lgtm, woo!
5 years, 3 months ago (2015-09-03 08:18:11 UTC) #4
pbos-webrtc
On 2015/09/03 08:18:11, pbos-webrtc wrote: > lgtm, woo! Also: I assume webrtc/p2p/client/connectivitychecker.* are not referred ...
5 years, 3 months ago (2015-09-03 08:19:04 UTC) #5
pbos-webrtc
On 2015/09/03 08:19:04, pbos-webrtc wrote: > On 2015/09/03 08:18:11, pbos-webrtc wrote: > > lgtm, woo! ...
5 years, 3 months ago (2015-09-03 08:56:54 UTC) #6
pthatcher1
On 2015/09/03 08:19:04, pbos-webrtc wrote: > On 2015/09/03 08:18:11, pbos-webrtc wrote: > > lgtm, woo! ...
5 years, 3 months ago (2015-09-03 17:06:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311353011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311353011/20001
5 years, 3 months ago (2015-09-04 06:40:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/5439) ios on tryserver.webrtc (JOB_FAILED, ...
5 years, 3 months ago (2015-09-04 06:41:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311353011/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311353011/60001
5 years, 3 months ago (2015-09-04 09:13:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/603)
5 years, 3 months ago (2015-09-04 09:31:20 UTC) #16
pthatcher1
5 years, 3 months ago (2015-09-04 11:21:20 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
d415629de78b84bf539fda7f634996e159b0dcaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698