Issue 1309903007: Revert of Revert "Move test cases for more natural ordering"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1309903007: Revert of Revert "Move test cases for more natural ordering" (Closed)

Created:
5 years, 3 months ago by rmistry

Modified:
5 years, 3 months ago

Reviewers:
the sun, stefan-webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Revert of Revert "Move test cases for more natural ordering" (patchset #1 id:1 of https://codereview.webrtc.org/1309313008/ ) Reason for revert: Not really reverting. Just testing the revert button for https://code.google.com/p/chromium/issues/detail?id=527325 Original issue's description: > Speculative revert of "Move test cases for more natural ordering." > > This reverts commit c20a5dc9305b988ca173cd63e606124b02e6d54c. > > BUG=webrtc:4959 > R=solenberg@webrtc.org > TBR=solenberg@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/02d283a6ff5364d94aa88f5f5df4cfd3a5411346 TBR=solenberg@webrtc.org,stefan@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4959

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+466 lines, -538 lines)			Patch
M	talk/media/base/videoengine_unittest.h	View	2 chunks	+0 lines, -26 lines	0 comments	Download
M	talk/media/webrtc/webrtcvideoengine2_unittest.cc	View	3 chunks	+145 lines, -155 lines	0 comments	Download
M	talk/media/webrtc/webrtcvoiceengine.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	talk/media/webrtc/webrtcvoiceengine_unittest.cc	View	4 chunks	+321 lines, -353 lines	0 comments	Download

Total messages: 2 (0 generated)

rmistry

Created Revert of Revert "Move test cases for more natural ordering"

5 years, 3 months ago (2015-09-03 16:57:39 UTC) #1

lgtm